Page 1 of 2

0.7.65: wrong ruler in "Any news" [RESOLVED]

Posted: Mon Mar 11, 2019 3:23 pm
by Ferital
When asking an NPC for any news, you can sometimes get information about a random new ruler of a random kindgom. But from what I remember in Classic, kindgoms with their ruler set in Factions.txt (Daggerfall, Sentinel, Wayrest, Anticlere, Lainlyn...) would use this one instead of generating a random name.

That's not the case in DFU:
Ruler news.png

Re: 0.7.65: wrong ruler in "Any news"

Posted: Wed Mar 13, 2019 7:23 pm
by Ferital
After investigating how classic works, I confirm there is an issue there. I'll submit a PR when I'll have time.

In classic, when you get information about the new ruler of any country, the game looks at first for a faction of type "facINDIVIDUAL" using the same region id as the country. And since Factions.txt contains many bugs, this can lead to odd news like that:
The Great Knight Lord of Ilessan Hills.PNG
:D

Re: 0.7.65: wrong ruler in "Any news"

Posted: Thu Mar 14, 2019 10:55 am
by R.D.
I found what the problem is. A faction's "flags" value is assigned from the faction file with =, when it should be |=. Some factions (Sentinel, at least), have their flags value across multiple lines for some reason. This causes only the last value to be used, so the "ruler immune" flag that is supposed to protect story factions from getting the new ruler event gets overwritten. I'm sending a PR for it now.

Re: 0.7.65: wrong ruler in "Any news"

Posted: Thu Mar 14, 2019 1:34 pm
by Ferital
Great! :)

Re: 0.7.65: wrong ruler in "Any news"

Posted: Sun Mar 24, 2019 8:02 am
by R.D.
Resolved now.

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Posted: Thu Apr 11, 2019 8:25 am
by Ferital
The issue is still present:
Wrong ruler.PNG

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Posted: Thu Apr 11, 2019 10:05 am
by Interkarma
Based on the nature of bug, any saves created prior to fix will likely still have issue. Source faction data is only read when character is created or persistent faction data is missing.

Something you could try is deleting the FactionFile.txt file from your save and reload game. This will force DFU to recreate the persistent faction data. Let me know if problem still persists after that and I'll re-open bug report. :)

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Posted: Thu Apr 11, 2019 12:42 pm
by Nystul
or delete ConversationData.txt ;)

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Posted: Thu Apr 11, 2019 12:50 pm
by Ferital
I first deleted FactionData.txt and the problem was still there (this time with the King of Daggerfall not being Gothryd). I then deleted ConversationData.txt and I can't get any news since then, I always get something like "I try not to spread rumors", even if I set "talk_npcsKnowEverything" using the console command.

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Posted: Thu Apr 11, 2019 8:39 pm
by Interkarma
The rumours in "any news" are on a rotation. They're not related to "knows everything". You just need to pass time until they recycle. Travel around for about 30 days and they'll get repopulated. Once you've reset your faction data, the next rumours generated should have correct ruler names.