Dev build/Linux: modded loot piles all contain the same items [RESOLVED]

[TheLacus]

Any models replacement mod triggers the bug.
As you suspected, the problem is MeshReplacement.ImportCustomFlatGameobject() resetting the random seed.

I thought we were talking about a sort of hash/id associated to each item instance. Random methods provided by Unity API use a global seed which is supposed to be set right before you use it. If the seed needs to persist, System.Random class can be used instead.

[pango]

UnityEngine.Random is used in many places in Daggerfall Unity without being (re)seeded.
Maybe System.Random could be used more often instead. UnityEngine.Random provides some nice utility methods like Range(float, float), but that could be fixed (say with extension methods?)...

[Interkarma]

It's just the seed being reset by model replacement during layout process. Have merged a fix now to reseed right before generating items.

UnityEngine.Random is used in many places in Daggerfall Unity without being (re)seeded.

The seed is being set at the start of dungeon layout process, of which dungeon loot generation is a part (otherwise the issue would be present even without mods). The problem is just that new code was introduced mid-stream of layout process that flattened seed. Due to the fact that loot can be generated anywhere (indoors, outdoors, dungeons, monsters, shops, etc.), it seems appropriate for this to be re-seeded anytime a loot collection is generated. I'm using current UID (which increments each time an item is generated) multiplied by realtime since startup. That will ensure nicely seeded treasure piles at all times.

There shouldn't be many cases like this. UnityEngine.Random is usually seeded properly at the start of the process before it's used. Loot is just a special case here that isn't part of any one process and needed some extra help.

[pango]

Glad to know the situation is under control

[Interkarma]

There's actually still something a bit screwy here. I'm able to reproduce the initial problem despite each loot pile being seeded before generation. It still happens after entering and exiting dungeon multiple time in a row. I'll keep digging on this one.

Edit: Well, found the cause. I was getting a bit too clever for my own good by multiplying the UID by realtimeSinceStartup and overflowing the seed int. I'll rework this one.