Duplicate store names using same block

[pango]

Got a temple quest to get some ingredients for free from the Arkcart Apothecary in Arkcart, Tulune.
To my surprise the town has two, not far from each other...

arkcart apothecary (dfu).jpg (251.34 KiB) Viewed 1514 times

According to Daggerfall classic, the right one is the right one.

arkcart apothecary.jpg (101.33 KiB) Viewed 1514 times

[Hazelnut]

Could you remove your discovery data for this location and see if that fixes it? (unless this is definitely the first visit with this save)

[pango]

First time in Arkcart; If I remove Arkcart entry from DiscoveryData, next time I identify the buildings they're both Arkcart Apothecary again.

[BadLuckBurt]

I had a quick look, both RMB blocks are ALCHAL03 and when I use 'dumpbuilding' inside both apothecaries, it's the same building again.

The NPCs have different names so that bug was fixed but it seems the buildings still end up with the same NameSeed, that's where the issue comes from.

[Hazelnut]

They should be using the location building data to get different names... will need to look and see what is broken here.

[BadLuckBurt]

They should be using the location building data to get different names... will need to look and see what is broken here.

I went and had a look in classic Daggerfall, they have different names there:



If I had to take a wild guess, RMB caching?

[pango]

I think this should be moved to bug reports, as "town blocks using the same model get aliased" or something

[Hazelnut]

Yes, forgot all about this one. I'll try and investigate when I get the chance,

[Hazelnut]

Right so I've looked into this one and there's good news and bad news. Good news is that the building pool matching code is working fine still since fixing it after the world data system was added. Unfortunately, the structs that are used to hold the data are being treated as pure value types but they contain arrays which are referenced. What is happening here is because the array of building data from the block is being modified with the building data from the location, it's using the same array because both copies of the block struct reference the same array object. So processing the second ALCHAL03 block ends up overwriting the first when it comes to the building array.

Now I just need to figure out where to replace the building array with a copy before it's updated with the building data and that should fix this bug. I do wish Visual Studio would show the memory addresses of variables - that would have made this a lot easier to track down!