Sprite Shadows not drawing/casting [RESOLVED]

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Sprite Shadows not drawing/casting

Post by pango »

What about a stupid bugfix?

Code: Select all

diff --git a/Assets/Scripts/Internal/DaggerfallBillboardBatch.cs b/Assets/Scripts/Internal/DaggerfallBillboardBatch.cs
index 13618f68..8239edc1 100644
--- a/Assets/Scripts/Internal/DaggerfallBillboardBatch.cs
+++ b/Assets/Scripts/Internal/DaggerfallBillboardBatch.cs
@@ -55,7 +55,7 @@ namespace DaggerfallWorkshop
         [Range(0, 30)]
         public float FramesPerSecond = 0;
         public bool RandomStartFrame = true;
-        public ShadowCastingMode ShadowCasting = ShadowCastingMode.On;
+        public ShadowCastingMode ShadowCasting = ShadowCastingMode.TwoSided;
         [Range(1, 127)]
         public int RandomWidth = 16;
         [Range(1, 127)]
Not pretending to understand what I'm doing :)
After messing with the code for a while, I realized that some mask was probably starting to be backlit...
Remembering that textures are usually only visible from one side, I asked the Internet, "unity do textures cast shadows from both sides?", andStackExchange replied...

I created a PR
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Midknightprince
Posts: 1324
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Sprite Shadows not drawing/casting

Post by Midknightprince »

Testing forthwith !
OMG, what a pleasant way to wake up :D
Check out my YouTube Channel!

User avatar
Midknightprince
Posts: 1324
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Sprite Shadows not drawing/casting

Post by Midknightprince »

ALL foliage sprites work !
The non-foliage sprites still seem to be turning off after 12 pm...
But the sunsets are gorgeous..
Attachments
3pm
3pm
Desktop Screenshot 2018.12.08 - 08.48.09.34.jpg (469.46 KiB) Viewed 1147 times
12:30 pm
12:30 pm
Desktop Screenshot 2018.12.08 - 08.43.29.07.jpg (411.81 KiB) Viewed 1147 times
sunset
sunset
Desktop Screenshot 2018.12.08 - 08.56.07.09.jpg (379.41 KiB) Viewed 1147 times
Check out my YouTube Channel!

User avatar
Midknightprince
Posts: 1324
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Sprite Shadows not drawing/casting

Post by Midknightprince »

Fixed
Check out my YouTube Channel!

Locked