Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

For bugs relating to quest scripts and quest system emulation.
Post Reply
User avatar
pango
Posts: 1749
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

Post by pango » Thu May 30, 2019 6:30 pm

In A0C10Y05 you escort some NPC to meet his/her betrothed NPC then escort them both to a temple to be married.
If you go directly to the temple and talk to the priest, the NPC you didn't go fetch will materialize at the same place as the priest (z-fighting together).
What makes the matter worse, fast travel from notebook will actually lead you directly to the temple (since it's the last thing mentioned in the quest, I assume). So this problem is even more likely to be experienced by players that do not take the time to read the quests...

(Problem first seen in a stream:
https://www.twitch.tv/videos/430364673?t=02h33m21s quest taken
https://www.twitch.tv/videos/430364673?t=02h35m18s fast travel
https://www.twitch.tv/videos/430364673?t=02h41m30s click on the priest
https://www.twitch.tv/videos/430364673?t=02h42m18s second click starts the marriage

By the way after that quest nobody wants to talk to him anymore, but it's hard to tell if that was to be expected, or is some other 2 quests he took that expired, or...
PS Seems your reputation in some random region can suffer from that quest, but what was the chance that random region was the current one? I suspect the issue is that the ruler is chosen to always come from the current region

Code: Select all

Person _ruler_ factiontype Province female
I think the quest should tell right away the region of the ruler, so that the player can make more informed choices.

Also, like in this case, the quest is often given by female NPCs

Code: Select all

Person _qgiver_ group Questor male

Another streamer that just followed fast travel from notebook destination in the same quest:
https://www.twitch.tv/videos/430134264?t=30m24s
But if the quest failed as it should if one goes straight to the temple, maybe they'd take more time reading quests?
That quest also ruined his regional reputation
)

Gamesave in front of the priest.
Attachments
SAVE300.zip
(289.64 KiB) Downloaded 58 times
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Jay_H
Posts: 2948
Joined: Tue Aug 25, 2015 1:54 am

Re: Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

Post by Jay_H » Fri May 31, 2019 2:14 am

The instant reward glitch is simple to fix. I've drafted a solution that I'll upload in the course of my fixes.

I need to see this one in classic. I don't remember the escorted NPCs getting placed into the temple at the end, but this is what happened when I tested it in DFU and what the quest file says should happen... It's odd.

I also have doubts that legal reputation should be affected by this quest.

User avatar
Jay_H
Posts: 2948
Joined: Tue Aug 25, 2015 1:54 am

Re: Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

Post by Jay_H » Sat Jun 08, 2019 3:53 am

I just spent the last hour or so trying to generate this quest in classic and it will not happen. I've tried everything I know. If someone can find footage of it on Youtube, that's about all I can think of now.

BansheeXYZ
Posts: 527
Joined: Fri Oct 23, 2015 8:19 pm

Re: Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

Post by BansheeXYZ » Sat Jun 08, 2019 7:47 am

Here's a save. It took me a while, but I got it. The quests requiring higher rep than 0 to trigger can be hard to get.
SAVE0.zip
(50.44 KiB) Downloaded 53 times

User avatar
Jay_H
Posts: 2948
Joined: Tue Aug 25, 2015 1:54 am

Re: Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

Post by Jay_H » Sat Jun 08, 2019 8:42 am

Ah, that's awesome! Thank you! :)



My beliefs were confirmed:

1. Legal reputation does not reduce because of this quest.
2. The NPCs are not placed into the temple when you talk to the priest. The quest file says they should but they do not. Perhaps they still carry the hidden property in classic?

(The video is a short proof but I looked everywhere on a previous attempt and they aren't there. Also, that "dagtext error" didn't show up the first time I did it.)

So the problem with reputation is here:

Code: Select all

Person _ruler_ factiontype Province female

_S.07_ task:
	when _S.05_ and _S.01_
	give pc _gold_ 
	change repute with _ruler_ by -20 
"factiontype Province" is conflating legal rep with provincial standing, which aren't the same thing in classic.

BansheeXYZ
Posts: 527
Joined: Fri Oct 23, 2015 8:19 pm

Re: Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

Post by BansheeXYZ » Sun Jun 09, 2019 8:22 am

In classic, if you go to the temple before fetching the woman, the priest is not clickable. In DFU, he is and the quest ends as if you had gotten both lovers. I think that's the main issue that needs fixed.

Spacing out the npc placement would also be a nice fix. I'm guessing placement of two npc billboards on exactly the same place silently fails in classic whereas it kinda works in the more robust DFU engine, with z-fighting.

User avatar
JorisVanEijden
Posts: 71
Joined: Mon Aug 12, 2019 5:02 pm

Re: Dev build/Linux: A0C10Y05: betrothed NPC appears on top of priest if you go directly to the temple

Post by JorisVanEijden » Sun Sep 01, 2019 1:51 pm

It looks like in classic the click on the priest is cleared again unless you've already clicked the betrothed.
DFU acts on it immediately before it can be cleared.

I created a workaround in PR https://github.com/Interkarma/daggerfal ... 1483/files
that should stop the quest from completing without getting the woman.

Post Reply