[0.12.2] Missing/duplicate stores in Oxville, Daggerfall [RESOLVED 0.12.3]

Locked
User avatar
KovuCougar
Posts: 61
Joined: Thu Aug 27, 2020 3:32 am

[0.12.2] Missing/duplicate stores in Oxville, Daggerfall [RESOLVED 0.12.3]

Post by KovuCougar »

It seems Oxville has gotten confused. In 0.12.2 and 0.12.1 tested with a clean start no mods.

The King's Smithy
Lord Mordoryan's Wares
Uthistyr's Finest Retail Store
Oxville's Best Gear (x2)
Bedyrick's General Wares (x2)
Missing:
Bargain Supplies
Trististair’s General Trading Post

Tested in an 0.10.27 I dug up, clean start, no mods and got the expected stores:
The King’s Smithy
Bargain Supplies
Lord Mordoryan’s Wares
Bedyrick’s General Wares
Oxville’s Best Gear
Uthistyr’s Finest Retail Store
Trististair’s General Trading Post

Images of the map are attached with stores discovered in both versions.
Spoiler!
Oxville-0.10.27.jpg
Oxville-0.10.27.jpg (47.53 KiB) Viewed 1050 times
Oxville-0.12.2.jpg
Oxville-0.12.2.jpg (46.53 KiB) Viewed 1050 times

User avatar
Jay_H
Posts: 3658
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: [0.12.2] Missing/duplicate stores in Oxville, Daggerfall

Post by Jay_H »

Yep, confirmed with no mods in 0.12.2. How odd.

Image

User avatar
KovuCougar
Posts: 61
Joined: Thu Aug 27, 2020 3:32 am

Re: [0.12.2] Missing/duplicate stores in Oxville, Daggerfall

Post by KovuCougar »

Looks like the block is the same (all the building positions are the same) so I'm guessing an error in enumeration somehow.

User avatar
Interkarma
Posts: 6511
Joined: Sun Mar 22, 2015 1:51 am

Re: [0.12.2] Missing/duplicate stores in Oxville, Daggerfall

Post by Interkarma »

Looks like a caching issue. I'll work back through recent PRs, but have an idea which change might have caused this regression. Cheers.

User avatar
Interkarma
Posts: 6511
Joined: Sun Mar 22, 2015 1:51 am

Re: [0.12.2] Missing/duplicate stores in Oxville, Daggerfall

Post by Interkarma »

I've supplied a potential fix below.

https://github.com/Interkarma/daggerfal ... a8c991447e

This code was removed during a previous PR, but it's needed to ensure unique names when same block used multiple times in one town. Provided this doesn't cause any other issues, fix will be in release after next (to be 0.12.4) as 0.12.3 is already cooked and in testing.

Please note that if you already have the duplicate names cached to discovery data in your save, then it will continue to display wrong for that character unless bad entries are manually removed from discovery data in that save.

Locked