[RESOLVED 0.10.14] Tabs in quest texts displaying as garbage

[pango]

Just seen in buckycarbon stream, tab characters display as (Unicode) garbage when formatted on screen:

quest text tabs.jpg (36.67 KiB) Viewed 1468 times

So either we must be sure to not use tabs in quest files, or the engine should be modified to correctly display spaces...

[Hazelnut]

It does display spaces correctly. For this sign off maybe the centre tag should be used. What quest is this?

[pango]

Only tabs are displayed wrong. That's K0C30Y03, message 1025
In Emacs whitespace-mode:

message 1025.jpg (31.18 KiB) Viewed 1460 times

[pango]

They seem rare, the only other occurrence I've found is in S0000009, Accept Quest message:

quest text tabs2.jpg (35.23 KiB) Viewed 1450 times

I haven't checked how this one actually displays...

[BadLuckBurt]

Usually when these appear, it's a character set issue. Notepad++ says both files are ANSI as UTF-8 which should be fine, the other files say the same. Perhaps there is some attempt at conversion taking place when Unity loads these particular files, trigged by lord knows what.

[Hazelnut]

No idea how they were introduced but they need changing to spaces.

[pango]

I submitted a PR

However this problem could easily come back...

[Jay_H]

Come on folks, we know who "someone" is No idea when that would've changed but I uploaded a fix.

EDIT: I closed mine. pango's is better

[BadLuckBurt]

I submitted a PR

However this problem could easily come back...

The only other way to deal with this is replace them in the strings as they're loaded in but I don't think that's worth it.

[pango]

Come on folks, we know who "someone" is No idea when that would've changed but I uploaded a fix.

Oops, Ninja'd by only 2 minutes!


What's strange is that it looks like the code is handling TABs specifically... but for some reason it doesn't work as expected :/