Page 1 of 3

Strengthens/Weakens Armor bug fix? [RESOLVED 0.10.24]

Posted: Tue Apr 21, 2020 4:23 am
by mikeprichard
Sorry if this isn't an appropriate question to ask here, but will someone please confirm whether the Strengthens/Weakens Armor enchantment bug reported under 10.21 (https://github.com/Interkarma/daggerfal ... ssues/1740) has already been fixed in 10.22, or will be fixed in 10.23? It seems like a pretty major but easily fixed issue (if the notes in the link are correct), but of course I'm not the one who has to do the work. Thank you!

Re: Strengthens/Weakens Armor bug fix?

Posted: Tue Apr 21, 2020 6:57 am
by Interkarma
I haven't confirmed this one yet. Once bug is confirmed and resolved, that will be in patch notes and issue will be closed.

Re: Strengthens/Weakens Armor bug fix?

Posted: Thu Apr 30, 2020 12:54 am
by Interkarma
Quick update, I've fixed this one now.

https://github.com/Interkarma/daggerfal ... 60234331e9

Re: Strengthens/Weakens Armor bug fix?

Posted: Thu Apr 30, 2020 5:26 am
by mikeprichard
Cheers! Was wondering why my daedric armor with that nice enchantment seemed to be so crappy... :) I assume/hope this will work on existing saves, including with an existing item with the "Strengthens Armor" enchantment?

Re: Strengthens/Weakens Armor bug fix?

Posted: Thu Apr 30, 2020 5:35 am
by Interkarma
Yep, it will work with existing saves. The actual business logic of the enchantment is applied at runtime. If in doubt, remove and re-equip your armour to reset effect completely.

Re: Strengthens/Weakens Armor bug fix?

Posted: Thu Apr 30, 2020 6:23 am
by mikeprichard
Perfect - thanks again.

Re: Strengthens/Weakens Armor bug fix?

Posted: Sat May 09, 2020 4:01 pm
by mikeprichard
Hello - a newly purchased bracer enchanted via the showitemmaker console with a "Strengthens Armor" enchantment in 10.23, when equipped, will not add 5 points to the paper doll inventory armor UI. I'm not sure whether this is only a UI issue, or the enchantment actually isn't working. Note that the attached save was started in 10.22 and only now resaved under 10.23. Thanks!

Re: Strengthens/Weakens Armor bug fix?

Posted: Sat May 09, 2020 8:33 pm
by Interkarma
Hi Mike, I'll move to bug reports so I don't lose track. Will comment when I can.

Re: Strengthens/Weakens Armor bug fix?

Posted: Sun May 10, 2020 2:07 am
by MaxRebo
Created pull request for this: https://github.com/Interkarma/daggerfal ... /pull/1818

This was mainly an issue with the armor modifier values being inverted - negative values correspond to higher armor. For the armor mod setter function in the player entity however it only set the value if the new value was higher than the current one, to always take the highest armor modifier rather than stacking armor modifiers - which is obv not gonna work for negative values - so it's not just a UI issue. Also the paper doll armor values were not being updated when unequipping accessories.

Re: Strengthens/Weakens Armor bug fix?

Posted: Sun May 10, 2020 11:18 am
by Hazelnut
Accessories can add armour? Is that right, if so I didn't know that.