[0.11.3] Bug when giving the totem to Gothryd [RESOLVED 0.15.1]

Locked
User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

[0.11.3] Bug when giving the totem to Gothryd [RESOLVED 0.15.1]

Post by pango »

As seen on CorentinWalou's stream, when trying to given the Totem of Tiber Septim to Gothryd, nothing happens until you leave Castle Daggerfall:
https://www.twitch.tv/videos/1038997661?t=2h12m55s

(Daggerfall Unity 0.11.3, unmodded. Wasn't that bug already fixed?)
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [0.11.3] Bug when giving the totem to Gothryd

Post by pango »

Problem still exists in 0.14.4
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Jay_H
Posts: 4061
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: [0.11.3] Bug when giving the totem to Gothryd

Post by Jay_H »

Somehow I never noticed this bug report (?!?!?!?!). I'll see what's happening!

User avatar
JorisVanEijden
Posts: 114
Joined: Mon Aug 12, 2019 5:02 pm

Re: [0.11.3] Bug when giving the totem to Gothryd

Post by JorisVanEijden »

The video is no longer available.
Can someone provide a save (preferably mod-free) right before giving the totem to Gothryd?

I'm mainly interested to see if the text "I see you have come to your senses. I should have you slain, ..." is shown (and when).

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [0.11.3] Bug when giving the totem to Gothryd

Post by pango »

I hope this one is okay, that's an old character so I can't tell exactly all the versions it went thru.
But I can reproduce the problem with him, text is displayed at the moment you appear outside of the castle:
2022_12_17_14_04_13.jpg
2022_12_17_14_04_13.jpg (101.76 KiB) Viewed 6206 times
Save in front of Gothryd, before clicking on him
Attachments
SAVE961.zip
(410.15 KiB) Downloaded 74 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
JorisVanEijden
Posts: 114
Joined: Mon Aug 12, 2019 5:02 pm

Re: [0.11.3] Bug when giving the totem to Gothryd

Post by JorisVanEijden »

I figured out the cause, but not yet a solution.

In DFU "when tasks" are "AlwaysOnTriggerCondition"s. This is not correct. But it's not as simple as changing that. A lot of the quests have been adjusted over the years to account for this.

In this case, the

Code: Select all

_S.07_ task:
	when not _S.06_ and _S.04_ 
should enable flag S.07 once and then not ever disable it again.

S.04 = PC picked up the Token
S.06 = PC is inside Daggerfall castle

Due to the wrong implementation (due to historical reasons) DFU disables S.07 again as soon as you enter the castle. And everything depending on S.07 will not trigger until you leave it.

I'll have a think on how to change this quest around so that it works as intended.

User avatar
JorisVanEijden
Posts: 114
Joined: Mon Aug 12, 2019 5:02 pm

Re: [0.11.3] Bug when giving the totem to Gothryd

Post by JorisVanEijden »

Can't edit or delete my posts?

Disregard what I said before. I was completely wrong. :oops:

I think an extra requirement to be outside the castle snuck in during one of the bugfixes on the QBN for this quest. :roll:

I opened a Pull Request to remove that requirement: https://github.com/Interkarma/daggerfal ... /pull/2482

Locked