[0.13.2b] Successful backstab and parry sound at the same time

Moderators will move topics here from Help & Support once an issue has been confirmed and enough information provided to reproduce.
Post Reply
User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

[0.13.2b] Successful backstab and parry sound at the same time

Post by pango »

Hi all,

Something a bit strange happened in the last TalonHatesNames stream, while hitting orcs in the back with a short blade he got (twice in the stream) both a successful backstab message, and a parry sound at the same time.
That felt unnatural, so I had a look at the code, the message is sent from inside FormulaHelper.CalculateBackstabDamage(), that's called only if CaclulateSuccessfulHit() returns true; On the other hand parry sounds should only happen when you do no damage.
I suppose it means the base damage was also 0, so that backstabbing tripled the base 0 damage? I don't quite get how this could happen...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: [0.13.2b] Successful backstab and parry sound at the same time

Post by Interkarma »

Thanks Pango. Moving to Issues to followup later.

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [0.13.2b] Successful backstab and parry sound at the same time

Post by pango »

Well, that's something that needs checking rather than a confirmed issue at that point...

I forgot to say he's playing unmodded 0.13.2b (unmodded as usual, until he finished the 18 predefined classes, already finished 15!), that's the predefined Nightblade run (so no bonus or phobia) and he was using a dwarven short sword.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: [0.13.2b] Successful backstab and parry sound at the same time

Post by Interkarma »

I'm happy for it to be in issues until confirmed, you have a good eye for this stuff. I also didn't want it to get lost.

I won't have time to check for a while. If anyone is able to test/confirm this one, it would be appreciated.

User avatar
Magicono43
Posts: 1139
Joined: Tue Nov 06, 2018 7:06 am

Re: [0.13.2b] Successful backstab and parry sound at the same time

Post by Magicono43 »

Kind of sounds like to me that the hit missed, but since the backstab attempt code happens before the final hit-chance is added all together and rolled, that means a backstab can technically succeed for the bonus damage roll part, but still miss. The miss in this case obviously defaulting to the parry sound instead of the normal "miss/swoosh" sound when attacking certain enemies. That's just my guess though what happened.

User avatar
Ralzar
Posts: 2211
Joined: Mon Oct 07, 2019 4:11 pm
Location: Norway

Re: [0.13.2b] Successful backstab and parry sound at the same time

Post by Ralzar »

Magicono43 wrote: Fri Apr 01, 2022 4:17 am Kind of sounds like to me that the hit missed, but since the backstab attempt code happens before the final hit-chance is added all together and rolled, that means a backstab can technically succeed for the bonus damage roll part, but still miss. The miss in this case obviously defaulting to the parry sound instead of the normal "miss/swoosh" sound when attacking certain enemies. That's just my guess though what happened.
And is that really an issue? I mean, you managed to stab them in the back but went clank against the armor :D

User avatar
Magicono43
Posts: 1139
Joined: Tue Nov 06, 2018 7:06 am

Re: [0.13.2b] Successful backstab and parry sound at the same time

Post by Magicono43 »

Ralzar wrote: Fri Apr 01, 2022 6:54 am
Magicono43 wrote: Fri Apr 01, 2022 4:17 am Kind of sounds like to me that the hit missed, but since the backstab attempt code happens before the final hit-chance is added all together and rolled, that means a backstab can technically succeed for the bonus damage roll part, but still miss. The miss in this case obviously defaulting to the parry sound instead of the normal "miss/swoosh" sound when attacking certain enemies. That's just my guess though what happened.
And is that really an issue? I mean, you managed to stab them in the back but went clank against the armor :D
I guess it would make a bit more sense if the backstab damage bonus roll happened after the check for if you missed entirely or not happened. But then again, might not be worth the potential mess that could make in terms of the general order of execution for the hit-formula, lol.

Post Reply