That would be Interkarma's decision.
Do "Critical Strike" skill affect Damage?
- mikeprichard
- Posts: 1037
- Joined: Sun Feb 19, 2017 6:49 pm
- Teralitha
- Posts: 359
- Joined: Wed Jul 17, 2019 3:44 pm
Re: Do "Critical Strike" skill affect Damage?
IF <------ "Dice100.SuccessRoll(attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike))mikeprichard wrote: ↑Fri Jul 19, 2019 3:22 pmI saw it and replied to your edit, but as Interkarma and TheLacus explained, that is what it says. Anyway, mods can change it if you or another would like to do so.Teralitha wrote: ↑Fri Jul 19, 2019 3:21 pmThats not quite what it says, look at my edited post above.mikeprichard wrote: ↑Fri Jul 19, 2019 3:20 pm
It's saying that Critical Strike skill gives a skill% chance to increase the hit chance by skill/10%. Yet again, I agree it's not the best mechanic, but there it is.
"Dice100.SuccessRoll(attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike))" refers to whether the Critical Strike skill roll is successful. That's the first check.
that makes a big difference. you left out the IF
- Teralitha
- Posts: 359
- Joined: Wed Jul 17, 2019 3:44 pm
Re: Do "Critical Strike" skill affect Damage?
Obviously. Whether or not it gets fixed, the game is still fun to play though as is. And honestly, from my observations playing the game, It seems that crits are actually doing extra damage. or something is.
Last edited by Teralitha on Fri Jul 19, 2019 3:32 pm, edited 2 times in total.
- mikeprichard
- Posts: 1037
- Joined: Sun Feb 19, 2017 6:49 pm
Re: Do "Critical Strike" skill affect Damage?
No; see my edits explaining the code further. We're ninja-ing each other's posts. Here it is again:
"[if] Dice100.SuccessRoll(attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike))" refers to whether the Critical Strike skill roll is successful. That's the first check.
"{chanceToHit += (attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike) / 10);}" refers to what happens if the first check is passed. In that case, chance to hit is increased by Critical Strike value/10.
Obviously, it is. DFU is Daggerfall on steroids.Teralitha wrote: ↑Fri Jul 19, 2019 3:26 pmObviously. Whether or not it gets fixed, the game is still fun to play though as is.
Last edited by mikeprichard on Fri Jul 19, 2019 3:33 pm, edited 7 times in total.
-
- Posts: 555
- Joined: Fri Oct 23, 2015 8:19 pm
Re: Do "Critical Strike" skill affect Damage?
Per Daggerfall's own manual:
- mikeprichard
- Posts: 1037
- Joined: Sun Feb 19, 2017 6:49 pm
Re: Do "Critical Strike" skill affect Damage?
Yeah, another of many instances where the manual was wrong compared to actual final game coding.
- Teralitha
- Posts: 359
- Joined: Wed Jul 17, 2019 3:44 pm
Re: Do "Critical Strike" skill affect Damage?
Exactly, from the manual description, the critical strike skill is about doing max damage, not about succesfully hitting.
- Teralitha
- Posts: 359
- Joined: Wed Jul 17, 2019 3:44 pm
Re: Do "Critical Strike" skill affect Damage?
Thats why it needs to be "fixed" And DFU is the perfect opportunity to do that.mikeprichard wrote: ↑Fri Jul 19, 2019 3:28 pm Yeah, another of many instances where the manual was wrong compared to actual final game coding.
- mikeprichard
- Posts: 1037
- Joined: Sun Feb 19, 2017 6:49 pm
Re: Do "Critical Strike" skill affect Damage?
It's a case where Interkarma would have to decide to follow what the manual says the game should do vs. what the game actually did. I would also prefer the former, but would understand the latter given Interkarma's DFU design philosophy since the very beginning.
- Teralitha
- Posts: 359
- Joined: Wed Jul 17, 2019 3:44 pm
Re: Do "Critical Strike" skill affect Damage?
Well he has already made many changes to the classic game. I think he means he is sticking to the "core" gameplay, not every minute detail. To be fair, I think an argument could be made that having crits could make combat pretty crazy, especially if the AI can do it to you. Maybe thats why the devs didnt do it in the final product.
Last edited by Teralitha on Fri Jul 19, 2019 3:36 pm, edited 2 times in total.