Re: Do "Critical Strike" skill affect Damage?
Posted: Fri Jul 19, 2019 2:59 pm
Right, seems clear to me as well - thanks for the confirmation, TheLacus.
Tools for Daggerfall
https://forums.dfworkshop.net/
That makes no sense. Why would a critical strike hit chance be applied after a normal hit chance is already rolled and successful? The whole premise is illogical.. But if this is from the classic game, then fine. No reason it cant be fixed rightTheLacus wrote: ↑Fri Jul 19, 2019 2:54 pmIf critical strike is applied successfully, it increases the chance that hit is successful. This is what the code above doesTeralitha wrote: ↑Fri Jul 19, 2019 2:37 pm "// Apply critical strike modifier.
if (Dice100.SuccessRoll(attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike)))
{
chanceToHit += (attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike) / 10);
}
"
When I read this, I am seeing.... when you make an attack, it checks to see if the hit is successful, and if it is, then it checks to see if a critical strike is successful(based on the skill %), and if so, it applies the critical strike effect. It doesnt tell us in that code what the critical strike effect is, just that its successful or not. The info that tells what the critical strike effect actually is would be somewhere else.
yeah it says that. but its also saying that it only works if you already have a successful hit from your other normal hit. So, your successful hit, is even more successful then? Doesnt make sense.TheLacus wrote: ↑Fri Jul 19, 2019 2:54 pmIf critical strike is applied successfully, it increases the chance that hit is successful. This is what the code above doesTeralitha wrote: ↑Fri Jul 19, 2019 2:37 pm "// Apply critical strike modifier.
if (Dice100.SuccessRoll(attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike)))
{
chanceToHit += (attacker.Skills.GetLiveSkillValue(DFCareer.Skills.CriticalStrike) / 10);
}
"
When I read this, I am seeing.... when you make an attack, it checks to see if the hit is successful, and if it is, then it checks to see if a critical strike is successful(based on the skill %), and if so, it applies the critical strike effect. It doesnt tell us in that code what the critical strike effect is, just that its successful or not. The info that tells what the critical strike effect actually is would be somewhere else.
It's saying that Critical Strike skill gives a % chance equal to your Critical Strike skill value to increase the overall hit chance by (Critical Strike skill value/10)%. Yet again, I agree it's not the best mechanic, but there it is.Teralitha wrote: ↑Fri Jul 19, 2019 3:19 pm yeah it says that. but its also saying that it only works if you already have a successful hit from your other normal hit. So, your successful hit, is even more successful then? Doesnt make sense.
To me it reads.. 'apply critical strike modifier IF you already have a successful hit." so... if the "critical strike modifier" is to boost your hit chance on an already successful hit... isnt that redundant?
Thats not quite what it says, look at my edited post above.mikeprichard wrote: ↑Fri Jul 19, 2019 3:20 pmIt's saying that Critical Strike skill gives a skill% chance to increase the hit chance by skill/10%. Yet again, I agree it's not the best mechanic, but there it is.
I saw it and replied to your edit, but as Interkarma and TheLacus explained, that is what it says. Anyway, mods can change it if you or another would like to do so. To clarify the code again:Teralitha wrote: ↑Fri Jul 19, 2019 3:21 pmThats not quite what it says, look at my edited post above.mikeprichard wrote: ↑Fri Jul 19, 2019 3:20 pmIt's saying that Critical Strike skill gives a skill% chance to increase the hit chance by skill/10%. Yet again, I agree it's not the best mechanic, but there it is.