Unity 2019.4.28f1 Point Upgrade + Linear Lighting & Lighting Review

Discuss Daggerfall Unity and Daggerfall Tools for Unity.
User avatar
Interkarma
Posts: 6527
Joined: Sun Mar 22, 2015 1:51 am

Unity 2019.4.28f1 Point Upgrade + Linear Lighting & Lighting Review

Post by Interkarma »

I've started work on a point update to Unity 2019.4.28f1 LTS (up from 2019.4.10f1). Please review the Unity Release Notes for all versions from .11 to .28 for engine changes. This update is required to support the final versions of Unity Localization system.

I will take this opportunity to include a few other changes that have been pending for a while:
  • Switch to linear lighting space.
  • Fix specular issues on classic materials to remove "washed out" or "glossy plastic" look in unmodded game. This will better reproduce classic palette at all times, particularly with retro mode palettization.
  • Lighting review to retune default lighting for linear, including places where lighting is overbright (e.g. snow in summer at midday).
  • Implement "ambient only" option for interiors so low-end computers can improve rendering interior speed.
  • Bump Daggerfall Unity version to 0.12.x.
This update will soon be available in pre-release. This means it will not be visible in Live Builds and only available for download via GitHub Releases.

This is likely to be the final engine point update before Daggerfall Unity 1.0 (due later in 2021). Modders should start preparing to be aligned with 0.12.x as it will be most representative of the 1.0 version of core. I will keep 0.12.x in pre-release for approximately two months before promoting to main main stable branch. This gives core developers plenty of time to fix issues relating to update, and modders lead time to start preparing new releases.

I've also started working through bug queues here on forums and GitHub. I plan to solve at least 90% or more of these before DFU is promoted to 1.0. Bug fix and refinement will continue into 1.0 and beyond.

User avatar
Interkarma
Posts: 6527
Joined: Sun Mar 22, 2015 1:51 am

Re: Unity 2019.4.28f1 Point Upgrade + Linear Lighting & Lighting Review

Post by Interkarma »

Reserved.

User avatar
Interkarma
Posts: 6527
Joined: Sun Mar 22, 2015 1:51 am

Re: Unity 2019.4.28f1 Point Upgrade + Linear Lighting & Lighting Review

Post by Interkarma »

Reserved.

User avatar
pango
Posts: 3049
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Unity 2019.4.25f1 Point Upgrade + Linear Lighting & Lighting Review

Post by pango »

Seems to have compiled fine under Linux (I had to explicitly rebuild addressables, but I think it was to be expected).
Loading a gamesave failed with several NullReferenceExceptions though, I don't know if I'm missing something, or if that's also to be expected at that point...

Code: Select all

NullReferenceException: Object reference not set to an instance of an object
  at DaggerfallWorkshop.Game.WeaponManager.SetMelee (DaggerfallWorkshop.Game.FPSWeapon target) [0x00000] in <a729b326cdc54c5886f845eb6867c9c5>:0 
  at DaggerfallWorkshop.Game.WeaponManager.Start () [0x00067] in <a729b326cdc54c5886f845eb6867c9c5>:0 
 
(Filename: <a729b326cdc54c5886f845eb6867c9c5> Line: 0)

NullReferenceException: Object reference not set to an instance of an object
  at DaggerfallWorkshop.Game.PlayerSpeedChanger.GetBaseSpeed () [0x00011] in <a729b326cdc54c5886f845eb6867c9c5>:0 
  at DaggerfallWorkshop.Game.PlayerMotor.Start () [0x00018] in <a729b326cdc54c5886f845eb6867c9c5>:0 
[...]
NullReferenceException: Object reference not set to an instance of an object
  at DaggerfallWorkshop.Game.WeatherManager.Start () [0x00034] in <a729b326cdc54c5886f845eb6867c9c5>:0 
[...]
NullReferenceException: Object reference not set to an instance of an object
  at DaggerfallWorkshop.Game.Utility.StartGameBehaviour.ApplyStartSettings () [0x0021b] in <a729b326cdc54c5886f845eb6867c9c5>:0 
  at DaggerfallWorkshop.Game.Utility.StartGameBehaviour.Start () [0x00000] in <a729b326cdc54c5886f845eb6867c9c5>:0 
[...]
Attachments
Player.log.zip
(30.16 KiB) Downloaded 44 times
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 6527
Joined: Sun Mar 22, 2015 1:51 am

Re: Unity 2019.4.25f1 Point Upgrade + Linear Lighting & Lighting Review

Post by Interkarma »

.25 has an issue where prefab links aren't preserved during upgrade.

https://issuetracker.unity3d.com/issues ... 1617873344

It's easy enough to fix core manually, but I do worry it might inconvenience modders if they have a lot of prefab linkages. It's something I'm sitting on for now. :)

User avatar
King of Worms
Posts: 4215
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Unity 2019.4.25f1 Point Upgrade + Linear Lighting & Lighting Review

Post by King of Worms »

This sounds exciting as hell to me :ugeek:

User avatar
Ralzar
Posts: 1971
Joined: Mon Oct 07, 2019 4:11 pm
Location: Norway

Re: Unity 2019.4.25f1 Point Upgrade + Linear Lighting & Lighting Review

Post by Ralzar »

Yeah. Biggest point of critique I have between DFU and Classic is that DFU looks a bit glossy and washed out compared to the darker and more vibrant colors in vanilla. So this will probably be a welcome upgrade.

As long as I still manage to get my mods working :D
My released mods

"I feel like Ralzar specifically wrote those mods for me and then said "Use them". Just so he could watch me die more."
-FuzzyBeanPlays

User avatar
Interkarma
Posts: 6527
Joined: Sun Mar 22, 2015 1:51 am

Re: Unity 2019.4.25f1 Point Upgrade + Linear Lighting & Lighting Review

Post by Interkarma »

I hope not to break too much Ralzar. :) I won't make a general release for a couple months, or until everything seems stable. And I won't move ahead until I'm happy with upgrade process.

TBH, I'm not very happy with that issue linked above. There are many prefab fields in core broken by this. I can restore them manually and get the build working, but it lowers my confidence in the process as I could miss something minor that's hard to diagnose later.

New Unity releases come out every couple of weeks and it's possible this will be fixed before I make much progress anyway. The actual point upgrade could end up being .26 or .27 based on this. I mainly wanted to give you all a heads-up and outline a few related goals.

User avatar
King of Worms
Posts: 4215
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Unity 2019.4.25f1 Point Upgrade + Linear Lighting & Lighting Review

Post by King of Worms »

Hi :)

Will we get some notice on when the 0.12.x is in pre-release? Or is it there somewhere for download and Im just blind? :D
Btw if I build my mod on Unity 2019.4.25f1 LTS - will it work on current 0.11.x release? (just so I can test it, not for distribution)

Thank you

User avatar
Hazelnut
Posts: 2867
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Unity 2019.4.25f1 Point Upgrade + Linear Lighting & Lighting Review

Post by Hazelnut »

It's not done yet KoW. I believe the plan is release 0.11.5, then work on the engine upgrade and release 0.12.0 for mods to test with and upgrade for (likely just a re-build) and which will have bugfixes of DFU if needed, and then v1.0 will finally be here.

(disclaimer, I might have mis-interpreted Interkarma's plans - he's in charge so gets to say what actually happens :D )
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

Post Reply