Magic item with wrong name.
-
pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Magic item with wrong name.
Here's a save with the Short Tunic of Venom Spitting already identified
- Attachments
-
- SAVE1319.rar
- (237.3 KiB) Downloaded 86 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
-
Interkarma
- Posts: 7242
- Joined: Sun Mar 22, 2015 1:51 am
Re: Magic item with wrong name.
No idea for now then. 
My best guess is the template data is being pulled from an unpatched game data source rather than the bundled JSON as expected. There are a few hands in that item process other than mine, so mental map is likely incomplete. Would need to review loot generation to confirm.
My best guess is the template data is being pulled from an unpatched game data source rather than the bundled JSON as expected. There are a few hands in that item process other than mine, so mental map is likely incomplete. Would need to review loot generation to confirm.
-
pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Magic item with wrong name.
It was King of Worms' reward for completing "Soul of a Lich", so that could be a quest reward thing:
https://www.twitch.tv/videos/852474769?t=1h1m30s
https://www.twitch.tv/videos/852474769?t=1h1m30s
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
-
Interkarma
- Posts: 7242
- Joined: Sun Mar 22, 2015 1:51 am
Re: Magic item with wrong name.
Thanks Pango. I can confirm this is game data. I've reviewed the process and ItemBuilder.CreateRegularMagicItem() invokes template data from MAGIC.DEF. So if game data is unpatched then old template name will inherit into DFU.
It looks like MagicItemTemplates data isn't used here after all, so my mental map is indeed incorrect. I'm using patched game data (via DaggerfallGameFiles) and don't experience the issue.
The data in MagicItemTemplates.txt is just a fixed version of MAGIC.DEF dumped to JSON. It should be trivial to use this template data instead of MAGIC.DEF. This was the intention when setting this data up, so I must have missed refactoring once it was ready.
Edit: Have refactored creating magical items to use the fixed JSON data instead of MAGIC.DEF now. This will correct future instances of this item from 0.11.1 and later. But items created before this version might still be based off wrong template - depending on user's game data.
https://github.com/Interkarma/daggerfal ... a13aead166
I can confirm this is game data. I've reviewed the process and ItemBuilder.CreateRegularMagicItem() invokes template data from MAGIC.DEF. So if game data is unpatched then old template name will inherit into DFU.It looks like MagicItemTemplates data isn't used here after all, so my mental map is indeed incorrect. I'm using patched game data (via DaggerfallGameFiles) and don't experience the issue.
The data in MagicItemTemplates.txt is just a fixed version of MAGIC.DEF dumped to JSON. It should be trivial to use this template data instead of MAGIC.DEF. This was the intention when setting this data up, so I must have missed refactoring once it was ready.
Edit: Have refactored creating magical items to use the fixed JSON data instead of MAGIC.DEF now. This will correct future instances of this item from 0.11.1 and later. But items created before this version might still be based off wrong template - depending on user's game data.
https://github.com/Interkarma/daggerfal ... a13aead166
-
RonFromHighRock
- Posts: 3
- Joined: Sun Dec 01, 2019 7:31 pm
Re: Magic item with wrong name.
Coming in late from a long history of playing Daggerfall. (In fact I still have it on a Pentium 90 that would probably boot up if I put a power supply in it) This was an issue with the original game, loaded from the original CD, as well as whatever the first attempt at a redo version (that ran on DOS Box) and also on a new PC with the files from the Daggerfall Unity with no mods loaded within the last month. Don't know if any of that is helpful but thought I would put it out there in case it is helpful.