Magic items not repairable

Post here if you need help getting started with Daggerfall Unity or just want to clarify a potential bug. Questions about playing or modding classic Daggerfall should be posted to Community.
Post Reply
Ommamar
Posts: 387
Joined: Thu Jul 18, 2019 3:08 am

Magic items not repairable

Post by Ommamar » Sun Aug 11, 2019 4:12 am

So I got lucky and found a vampiric sword in Privateer's Hold but when I tried to have it repaired at Grondyk's Shields in Wayrest I got the can repair magic item message. Since I had just updated builds (thanks for everyone's hard work) I thought maybe things had reset, a look at the DFU option shows I had the repair magic items box checked. Is there only particular smiths that can do it? Is it tied to mage guild faction some how?

User avatar
Interkarma
Posts: 4863
Joined: Sun Mar 22, 2015 1:51 am

Re: Magic items not repairable

Post by Interkarma » Sun Aug 11, 2019 4:42 am

Magic items should be repairable so long as the option is checked. It could be a regression caused by a recent PR. I'll tag Hazelnut to take a look.

Edit: Just had a quick look at the code myself, and it doesn't look like the allow magic repairs flag was being observed at all. Was this just not working before?

Pushed fix to git now and tested magic items can be repaired. Fix will be in next round of builds.

Ommamar
Posts: 387
Joined: Thu Jul 18, 2019 3:08 am

Re: Magic items not repairable

Post by Ommamar » Sun Aug 11, 2019 3:11 pm

"Edit: Just had a quick look at the code myself, and it doesn't look like the allow magic repairs flag was being observed at all. Was this just not working before?"-interkarma

I don't know only ever repair weapons and this was the first magic weapon I had gotten so never tried it on last build.

Looks like you got it fixed now so guess it is a mute question, thanks for the prompt work!

Post Reply