VideoPlayer possible improvements

Post here if you need help getting started with Daggerfall Unity or just want to clarify a potential bug. Questions about playing or modding classic Daggerfall should be posted to Community.
Post Reply
User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

VideoPlayer possible improvements

Post by pango »

In a stream that featured the Lysandus video I noticed:
  • music continued playing in background during the video. I suspect the issue is that the MIDI synthesis case is covered, but not the sampled music case;
  • the video skipped the first time around. Given it''s triggered by clicking on the sarcophagus, I suspect the click got thru and interrupted the video. Maybe some hardening is required here (or enable abort on Escape key only for quest videos)
I tried fixing it myself, pluging on existing OnVideoStart/OnVideoEnd delegates, also blocking ambient sounds during video playback because why not; Main quest videos only play indoors, but who knows where videos could be played by a quest...
But it didn't seem to work, like they're not called. I'm a bit puzzled.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: VideoPlayer possible improvements

Post by pango »

Mmmh looks like C#/Unity compilation is playing tricks on me again. I removed the build subdirectory to be sure my code was compiled in, and surprize it works now...

I submitted a PR
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
King of Worms
Posts: 4753
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: VideoPlayer possible improvements

Post by King of Worms »

Thanks for fixing the issue!

Post Reply