The Lucky Djinn (possible bug) [FIX UPLOADED]
- Jay_H
- Posts: 4072
- Joined: Tue Aug 25, 2015 1:54 am
- Contact:
Re: The Lucky Djinn (possible bug)
Pull Request, a method to merge data in github.
-
- Posts: 13
- Joined: Sun Nov 10, 2019 3:03 pm
Re: The Lucky Djinn (possible bug)
Ah. I never really learned how to use git hub or anything about it honestly. I know how to download files from linked pages, that's about it. Does that mean there's a fix available, or was it just a fix added in for the next release?
There are three things all wise men fear:
The Sea in Storm
A Night with no Moon
And the Anger of a Gentle Man
The Sea in Storm
A Night with no Moon
And the Anger of a Gentle Man
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: The Lucky Djinn (possible bug)
It just means fix available for review. Once it passes review and gets merged into live code, it will be included in next release.
Unless I find a problem with it, it will be in November builds towards end of month.
Unless I find a problem with it, it will be in November builds towards end of month.
-
- Posts: 13
- Joined: Sun Nov 10, 2019 3:03 pm
Re: The Lucky Djinn (possible bug)
Ah alrighty. Thanks for explaining.
There are three things all wise men fear:
The Sea in Storm
A Night with no Moon
And the Anger of a Gentle Man
The Sea in Storm
A Night with no Moon
And the Anger of a Gentle Man
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: The Lucky Djinn (possible bug)
It should also be noted that Uncanny Valley will need to make a few minor changes to a few of the override files in the mod for the fix to work fully and give the exact same names as without the mod.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- Rand
- Posts: 72
- Joined: Sat Nov 23, 2019 5:10 am
- Location: Canada
Re: The Lucky Djinn (possible bug) [FIX UPLOADED]
Will there be an update here on the status of this? I'm interested, too, and while I can monitor the mod page, I'm not sure where the info on the live code change would be.
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: The Lucky Djinn (possible bug) [FIX UPLOADED]
Yes, if I remember to. The PR is in the queue, so hopefully will be in a release soon. I've not had anything from Uncanny Valley but I assume he's seen what I wrote in his thread.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- Rand
- Posts: 72
- Joined: Sat Nov 23, 2019 5:10 am
- Location: Canada
Re: The Lucky Djinn (possible bug) [FIX UPLOADED]
An update was posted listing the requirement as the latest build (10.12) so I have to assume it includes the fix.