I agree. I tested this quickly before I was off to bed because this bugged me for a whileInterkarma wrote: ↑Mon Nov 25, 2019 1:53 am
BadLuckBurt's solution above should be fine if Hazelnut is happy with it. I can't recall why this was changed back in 2018. It's mainly important the seed is deterministic and unique per building in each location. I'd definitely want Hazelnut's take on this first.
All Homes Locations owned by the same NPC?
- BadLuckBurt
- Posts: 948
- Joined: Sun Nov 05, 2017 8:30 pm
Re: All Homes Locations owned by the same NPC?
DFU on UESP: https://en.uesp.net/w/index.php?title=T ... fall_Unity
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt
.
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt
.
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: All Homes Locations owned by the same NPC?
I will look at this when I get back. Just wanted to say this is something I was aware of after a conversation between Burt and I on discord quite recently, but before this post. I didn't immediately do anything about it because no one had noticed. Then shortly someone did and posted about it... life is funny sometimes.
Anyway, the names are only the same when a block is in the same position for a location. Obviously for locations with a single block, this is all locations using that block.
I think there may be a knock on effect from that suggestion Burt, but I will check it once I am back home and have had some sleep so my eyes can focus again.
Anyway, the names are only the same when a block is in the same position for a location. Obviously for locations with a single block, this is all locations using that block.
I think there may be a knock on effect from that suggestion Burt, but I will check it once I am back home and have had some sleep so my eyes can focus again.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- BadLuckBurt
- Posts: 948
- Joined: Sun Nov 05, 2017 8:30 pm
Re: All Homes Locations owned by the same NPC?
I did look a bit further and I think that passing the locationIndex as a separate parameter would be better. I hadn't realised the buildingKey is being saved with the NPC so if that's used for any logic checks they'll fail because the original buildingKey is different.
In it's current state it's harmless thankfully.
DFU on UESP: https://en.uesp.net/w/index.php?title=T ... fall_Unity
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt
.
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt
.
- The Holy Knight
- Posts: 47
- Joined: Wed Jun 26, 2019 11:51 pm
Re: All Homes Locations owned by the same NPC?
I Just saw that it does it in city residences with the same interior but the shops have different NPC names
- BadLuckBurt
- Posts: 948
- Joined: Sun Nov 05, 2017 8:30 pm
Re: All Homes Locations owned by the same NPC?
Cant look at the code right now but shops are probably handled differently, good to know either way so thank you for mentioning itThe Holy Knight wrote: ↑Mon Dec 16, 2019 8:58 am I Just saw that it does it in city residences with the same interior but the shops have different NPC names
DFU on UESP: https://en.uesp.net/w/index.php?title=T ... fall_Unity
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt
.
DFU Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt
.
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: All Homes Locations owned by the same NPC?
I forgot all about looking at this one when I got back. Will look soon.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- The Holy Knight
- Posts: 47
- Joined: Wed Jun 26, 2019 11:51 pm
Re: All Homes Locations owned by the same NPC?
Its alright haha, I just had noticed it in a city after I had done a quest in another city in the same interior model and I realized the same name on the npc, I never guessed to check the city interiors