[RESOLVED 0.10.14] Dead body drop sound volume

Locked
User avatar
Yagiza
Posts: 120
Joined: Wed Jul 31, 2019 5:16 pm

[RESOLVED 0.10.14] Dead body drop sound volume

Post by Yagiza »

Sound, which played when enemy died, played at maximum volume even if SFX volume set to zero. Other SFX played with correct volume.

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dead body drop sound volume

Post by pango »

Good spotting! It seems to be the only use of AudioSource.PlayClipAtPoint() in Daggerfall Unity, so it was forgotten and not updated like other sounds generation.

Interestingly, PlayOneShot() is not used here because the enemy body is just about to be deactivated (and so would its audio sources), while the corpse has no audio source; So the simplest solution seems to have been to play a sound detached from any game object...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dead body drop sound volume

Post by pango »

I submitted a PR
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7247
Joined: Sun Mar 22, 2015 1:51 am

Re: Dead body drop sound volume

Post by Interkarma »

Thanks for the quick fix Pango. :)

User avatar
pango
Posts: 3359
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dead body drop sound volume [FIX UPLOADED]

Post by pango »

This should be fixed since 0.10.14
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Locked