Page 2 of 2

Re: Correcting more classic Item Maker inconsistencies

Posted: Sun Apr 12, 2020 7:39 am
by pango
@Interkarma I don't think you said anything about those changes:

Code: Select all

1) "Cast When Strikes" should only be listed in the Item Maker UI for weapons.
2) "Vampiric Effect: When Strikes" should only be listed in the Item Maker UI for weapons.
Does the small patch I posted make sense, should I make a PR out of it?

Re: Correcting more classic Item Maker inconsistencies

Posted: Sun Apr 12, 2020 7:54 am
by Interkarma
Yes, I agree it makes sense for those enchants to only apply to weapons. Setting the flag as you say will do the trick. I'm happy if you want to make a PR for this. :)

Re: Correcting more classic Item Maker inconsistencies

Posted: Sun Apr 12, 2020 8:18 am
by pango
Done.

Thanks Mike!

Re: Correcting more classic Item Maker inconsistencies

Posted: Sun Apr 12, 2020 9:50 am
by Interkarma
Legend :)

Re: Correcting more classic Item Maker inconsistencies

Posted: Sun Apr 12, 2020 2:30 pm
by mikeprichard
Great - thank you both!

Re: Correcting more classic Item Maker inconsistencies

Posted: Sat May 09, 2020 3:59 pm
by mikeprichard
pango wrote: Sun Apr 12, 2020 7:39 am @Interkarma I don't think you said anything about those changes:

Code: Select all

1) "Cast When Strikes" should only be listed in the Item Maker UI for weapons.
2) "Vampiric Effect: When Strikes" should only be listed in the Item Maker UI for weapons.
Does the small patch I posted make sense, should I make a PR out of it?
Hello - armor/shields, clothing, and miscellaneous items may still be enchanted with the "Vampiric Effect: When Strikes" enchantment via the showitemmaker console in DFU 10.23, at least in my attached save. Note that this save was started in 10.22 and only now resaved under 10.23. Thanks!

Re: Correcting more classic Item Maker inconsistencies

Posted: Tue May 12, 2020 8:01 pm
by mikeprichard
Has my reported remaining issue just above been confirmed for a future fix, or do I need to do more testing? Note that I did only test using the 10.23 "showitemmaker" console and not a real item maker NPC, as I was too lazy to cheat my character's stats up to meet the Mage's Guild rank requirement. ;)

Re: Correcting more classic Item Maker inconsistencies

Posted: Tue May 12, 2020 9:59 pm
by Interkarma
mikeprichard wrote: Sat May 09, 2020 3:59 pm Hello - armor/shields, clothing, and miscellaneous items may still be enchanted with the "Vampiric Effect: When Strikes" enchantment via the showitemmaker console in DFU 10.23, at least in my attached save. Note that this save was started in 10.22 and only now resaved under 10.23. Thanks!
I vetoed this one on git, Mike. The flag to restrict enchantments to weapons is available only to the parent of an effect group (Vampiric Effect). Setting this without additional code changes would have confined both effects in this group to weapons, including the At Range variant. It's better just to leave as-is for now.

To set this up correctly will require new support in the enchantment system to filter out sub-effects of an effect group to weapons only. This is a design issue (albeit one informed by the classic game we're recreating) that isn't trivial to overcome with other things on my plate right now.

Re: Correcting more classic Item Maker inconsistencies

Posted: Tue May 12, 2020 10:33 pm
by mikeprichard
Ah, understood - I had made a note on the relevant UESP page about a pending bug fix in DFU on this issue, but it does seem to be more work than warranted right now, so I'll revert. Thanks for the follow-up.