- if you conjure arrows several times, they're all stacked with the existing time-to-live; So newly created arrows disappear sooner than they should. I think only arrows with the same TTL should be stackable.
- When shooting arrows, real arrows take priority over conjured arrows, that's most likely never what the player wants. If 1. is fixed, conjured arrows with the shortest TTL should be picked first, and real arrows last.
- Arrows counter could then benefit from some indicator telling whether you're about to shoot real or conjured arrows, or display separate counters.
- Arrows counter doesn't work with classic HUD. But hey, that's not a classic feature, so it's not really a bug.
- You may retrieve a mix of arrow types off a corpse, that will probably need some adjustments.
Shortcomings with conjured arrows
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Shortcomings with conjured arrows
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Shortcomings with conjured arrows
About 5., it seems that if you hit an enemy with a conjured arrow, the arrow becomes real in the loot Whoops!
https://github.com/Interkarma/daggerfal ... er.cs#L547
https://github.com/Interkarma/daggerfal ... er.cs#L547
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Shortcomings with conjured arrows
The latter is probably harder to fix than I thought. I think summoned items are only handled specifically in player's inventory.
Simplest fix may be for summoned arrows to vanish after use, does it look acceptable? They have a limited lifespan in the first place...
Simplest fix may be for summoned arrows to vanish after use, does it look acceptable? They have a limited lifespan in the first place...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Shortcomings with conjured arrows
I submitted a PR
I didn't try to fix point 4. (displaying arrows counter with classic HUD). I saw a comment about that in the code
so I'm not sure what to do about that.
I didn't try to fix point 4. (displaying arrows counter with classic HUD). I saw a comment about that in the code
Code: Select all
// TODO: Find a spot for arrow counter when large HUD enabled (remembering player could be in 320x200 retro mode)
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: Shortcomings with conjured arrows
This is nice work Pango, thank you.
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Shortcomings with conjured arrows
And thanks TalonHatesNames for bringing those issues to my attention
https://www.twitch.tv/videos/937492345
https://www.twitch.tv/videos/937492345
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Shortcomings with conjured arrows
(watching more of his stream)
He also expected Create Item spell to have an icon while active.
Which would have the benefit of being compatible with the large HUD, or disabled arrow counter...
I don't know how to do that though.
He also expected Create Item spell to have an icon while active.
Which would have the benefit of being compatible with the large HUD, or disabled arrow counter...
I don't know how to do that though.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: Shortcomings with conjured arrows
I wonder if rather than multiple stack of arrows with different TTLs, if the conjured arrows should instead always stack with each other and reset the stack TTL with latest cast. This saves the inventory being cluttered with multiple arrow stacks, and user is just "topping up" their stack occasionally.
Create Item in DF is an instant cast spell and has no icon in classic either. The timer is handled as a countdown on the item itself while the spell is transitory. But then again, we only did it that way because that's how classic handled it. The effect could be refactored so that spell persists for life of item, then either sets item kill timer when spell expires or deletes item directly. Then there would be an icon on HUD so long as magic rounds remain.
Create Item in DF is an instant cast spell and has no icon in classic either. The timer is handled as a countdown on the item itself while the spell is transitory. But then again, we only did it that way because that's how classic handled it. The effect could be refactored so that spell persists for life of item, then either sets item kill timer when spell expires or deletes item directly. Then there would be an icon on HUD so long as magic rounds remain.
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: Shortcomings with conjured arrows
I doubt many people who are playing 320x200 retro mode with the large HUD will want enhancements like the arrow counter, so I wouldn't sweat it too much on this QoL feature guys.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: Shortcomings with conjured arrows
That's a fair point Hazelnut.