Page 4 of 5

Re: Daggerfall Unity 0.10.16

Posted: Thu Jan 30, 2020 12:10 am
by Interkarma
Thanks so much Pango! :)

Re: Daggerfall Unity 0.10.18

Posted: Thu Jan 30, 2020 9:46 am
by King of Worms
Thanks for the update :)

Re: Daggerfall Unity 0.10.18

Posted: Thu Jan 30, 2020 3:43 pm
by L57
pango wrote: Wed Jan 29, 2020 5:49 pm [*] Don't suppress world when inside a building (Ferital)
Probably a stupid question, but could you explain what does it mean? :)

Re: Daggerfall Unity 0.10.18

Posted: Thu Jan 30, 2020 4:03 pm
by Ralzar
L57 wrote: Thu Jan 30, 2020 3:43 pm
pango wrote: Wed Jan 29, 2020 5:49 pm [*] Don't suppress world when inside a building (Ferital)
Probably a stupid question, but could you explain what does it mean? :)
I was going to ask the same question :)

Re: Daggerfall Unity 0.10.16

Posted: Thu Jan 30, 2020 4:22 pm
by Jay_H
I haz an answer! :D https://github.com/Interkarma/daggerfal ... /pull/1655
Fix list of houses for sale not available when loading the game inside a bank

Re: Daggerfall Unity 0.10.18

Posted: Thu Jan 30, 2020 7:22 pm
by Ferital
L57 wrote: Thu Jan 30, 2020 3:43 pm
pango wrote: Wed Jan 29, 2020 5:49 pm [*] Don't suppress world when inside a building (Ferital)
Probably a stupid question, but could you explain what does it mean? :)
Yes, the commit message was not very clear as it was mostly intended for devs. The bug was that when loading a game inside a building, the exterior world was suppressed, i.e. it wasn't loaded at all until the player exited the building. This led to a few issues like the houses for sale list one: since the game didn't have any available town information, it couldn't construct the list. "World suppression" was probably a leftover from DFU early days, when exterior loading was relatively slow, which isn't the case anymore.

Re: Daggerfall Unity 0.10.18

Posted: Thu Jan 30, 2020 7:36 pm
by L57
Ferital wrote: Thu Jan 30, 2020 7:22 pm Yes, the commit message was not very clear as it was mostly intended for devs. The bug was that when loading a game inside a building, the exterior world was suppressed, i.e. it wasn't loaded at all until the player exited the building. This led to a few issues like the houses for sale list one: since the game didn't have any available town information, it couldn't construct the list. "World suppression" was probably a leftover from DFU early days, when exterior loading was relatively slow, which isn't the case anymore.
Thanks! By the way, could you also explain how does the game select available houses for sale? I suspect these buildings are pre-defined in city blocks?

Re: Daggerfall Unity 0.10.18

Posted: Thu Jan 30, 2020 8:35 pm
by Ralzar
Ferital wrote: Thu Jan 30, 2020 7:22 pm
L57 wrote: Thu Jan 30, 2020 3:43 pm
pango wrote: Wed Jan 29, 2020 5:49 pm [*] Don't suppress world when inside a building (Ferital)
Probably a stupid question, but could you explain what does it mean? :)
Yes, the commit message was not very clear as it was mostly intended for devs. The bug was that when loading a game inside a building, the exterior world was suppressed, i.e. it wasn't loaded at all until the player exited the building. This led to a few issues like the houses for sale list one: since the game didn't have any available town information, it couldn't construct the list. "World suppression" was probably a leftover from DFU early days, when exterior loading was relatively slow, which isn't the case anymore.
Riiight. That’s the problem Hazelnut and me ran into testing Mountain Rumours. If you loaded a save inside a fort and left you loaded inside the stairs.

Re: Daggerfall Unity 0.10.18

Posted: Fri Jan 31, 2020 8:09 am
by Ferital
L57 wrote: Thu Jan 30, 2020 7:36 pm
Ferital wrote: Thu Jan 30, 2020 7:22 pm Yes, the commit message was not very clear as it was mostly intended for devs. The bug was that when loading a game inside a building, the exterior world was suppressed, i.e. it wasn't loaded at all until the player exited the building. This led to a few issues like the houses for sale list one: since the game didn't have any available town information, it couldn't construct the list. "World suppression" was probably a leftover from DFU early days, when exterior loading was relatively slow, which isn't the case anymore.
Thanks! By the way, could you also explain how does the game select available houses for sale? I suspect these buildings are pre-defined in city blocks?
They are predefined in classic, but as we couldn't use the original data, in DFU they are selected at random (which is much better in my opinion). Hazelnut did this part of the code.

Re: Daggerfall Unity 0.10.18

Posted: Fri Jan 31, 2020 8:19 am
by L57
Ferital wrote: Fri Jan 31, 2020 8:09 am They are predefined in classic, but as we couldn't use the original data, in DFU they are selected at random (which is much better in my opinion). Hazelnut did this part of the code.
It's rather risky to edit city buildings then? I'm obsessed with the idea of reworking some residences into workshops and manufactories (really hate the lack of a visible economical activity in the game)... or at least to rename these buildings and make them temporarily unaccessible until I can/learn to edit these interiors.

Now wondering how many problems will it cause given DFU implementation.