Sorry, I thought pull requests were a way to request those changes! I thought it would be easier to send you the code to review and test (though I could have done a better job explaining the why in the first few commit comments etc.). To be clear, I wasn't sending pull requests with the expectation you would commit changes them just because I asked
Nystul wrote:Git is somehow behaving very strange... doesn't behave like I would expect it...
I did a pull-request with the changes to the "location" command. nothing else.
AFTERWARDS I proceeded IN MY work-in-progress fork with new changes. I commited locally and pushed TO MY fork - somehow it did automatically change the pull-request how it seems... I never did extend the pull-request nor did a do another pull-request
I never intended to add the new changes to the pull request (how did I mess this up?)
what did I do wrong? I really need to know so this doesn't happen again... Is it forbidden to work on new changes until the last pull-request is closed? This would be stupid - so it must have been a error on my side - but how?
Yes, that is actually how it works - your pull request will be auto-updated as you push to the branch you committed from. I found that out too
http://codeinthehole.com/writing/pull-r ... ng-github/
It allows you to submit multiple pull requests without confusion. The classical Github gotcha is to continue committing to a pull request branch after making the initial request. When these commits are pushed to the remote, they will become part of the original pull request which often ends up conflating unrelated functionality.
I'm assuming it's fine to do something like push a branch with the updates, send a pull request, and after it has been merged just delete it?