Build 0.5.477: Knightly Order quest "The Princess" [RESOLVED]

FilthyCasual523
Posts: 64
Joined: Tue Feb 06, 2018 6:06 am

Build 0.5.477: Knightly Order quest "The Princess" [RESOLVED]

Post by FilthyCasual523 »

I'm doing "The Princess" for the Knights of the Dragon, and I find the princess is... well...
20180901235320_1.jpg
20180901235320_1.jpg (216.6 KiB) Viewed 3853 times
Needless to say, I'm very confused.

The little portrait on the side of the screen once you start escorting her back to the order hall also seems to shift between male and female at random in between instances of this quest.

Not currently using mods.

User avatar
Jay_H
Posts: 4062
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by Jay_H »

When you click on him, by any chance did he tell you your princess is in another castle? :lol:

In any case, this is a simple fix. The data in the quest file tells the story:

Code: Select all

Person _lady_ face 2 group Noble
Usually there's a parameter defining the person as male or female, but in this case classic depended on the face parameter to always make it the same graphic, I think. In any case I can modify that when I have a chance.

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by R.D. »

There was just a fix related to quests and gender in the last few days. Any chance it fixed this one?

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by Interkarma »

That fix was for static NPCs injected as questors, this one looks like a virtual NPC.

I think issue is simply that quest fails to define gender, which results in 50/50 shot for virtual NPCs. A well-written quest should define gender when related to plot.

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by pango »

B0B00Y00.txt:

Code: Select all

Person _lady_ face 2 group Noble
How can it be fixed, is adding "female" keyword there sufficient?
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Jay_H
Posts: 4062
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by Jay_H »

Yes, that's the solution.

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by Hazelnut »

Have we decided that's the way we're going to fix it? I though that was still in doubt. Happy to fix the quests if a decision has been made.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by pango »

That was not sufficient, or I didn't do it right...

Code: Select all

Person _lady_ face 2 group Noble female
princess rescue.jpg
princess rescue.jpg (272.51 KiB) Viewed 3441 times
At least the face was female, hopefully not just by chance...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 7236
Joined: Sun Mar 22, 2015 1:51 am

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by Interkarma »

Thanks guys, I'll look into why the gender tag didn't work for that static NPC sprite selection. That should have worked.

This is still the correct solution for the quest though. For NPCs like this that are spawned completely by quest, informing the quest engine what the gender is supposed to be is a must (when it matters for a the narrative anyway).

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build 0.5.477: Knightly Order quest "The Princess"

Post by Hazelnut »

Pango, did you change the quest script before accepting the quest?
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

Locked