Dev build/Linux: (minor) buying premade spells one at a time [RESOLVED]

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Dev build/Linux: (minor) buying premade spells one at a time [RESOLVED]

Post by pango »

Minor UI bug, when you buy a premade spell from a merchant, you're dropped back into the world, instead of going back to the list of spells. This is inconsistent with other shops (and with Daggerfall classic)

Savegame in front of a spell merchant, if this can save some time
Attachments
SAVE73.zip
(189.42 KiB) Downloaded 85 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by R.D. »

(and with Daggerfall classic)
I just tested classic, but it drops you back into the world as well.
It might be better design if it returned you to the list of spells, though.

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by pango »

Weird, mine doesn't, I checked again
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Hazelnut
Posts: 3015
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by Hazelnut »

Matches classic for me as well - when using DOSBox, it drops back to world.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Midknightprince
Posts: 1324
Joined: Fri Aug 11, 2017 6:51 am
Location: San Antonio TX
Contact:

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by Midknightprince »

It stays in the buy window for me in classic (I wonder what you guys have installed, Daggerfall setup has a bunch of stuff), but in unity it exits the window when you buy a spell.

Win10 64bit here
Check out my YouTube Channel!

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by pango »

Last edited by pango on Sat Dec 01, 2018 11:26 pm, edited 2 times in total.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

BansheeXYZ
Posts: 555
Joined: Fri Oct 23, 2015 8:19 pm

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by BansheeXYZ »

I suggested this and other minor QOL interface changes in the features forum. No one responded.

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by pango »

I created a pull request for that.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

BansheeXYZ
Posts: 555
Joined: Fri Oct 23, 2015 8:19 pm

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by BansheeXYZ »

I see what's happening. In classic, if you double-click a spell to buy it, the window closes. But if you click the "buy" button, it doesn't. DFU just closes either way. Like me, Interkarma probably never used the buy button and assumed the behavior was the same.

Safe to say it's a bug in classic then that is being copied in DFU. Double-clicking to buy should not behave inferior to clicking the buy button.

User avatar
pango
Posts: 3347
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: (minor) buying premade spells one at a time

Post by pango »

BansheeXYZ wrote: Sun Dec 02, 2018 9:24 am if you double-click a spell to buy it, the window closes. But if you click the "buy" button, it doesn't. DFU just closes either way.
Good catch! I checked with Daggerfall classic, and this is indeed what's happening.
I updated my pull request to emulate that.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Locked