Build #135: Questgiver name doesn't match log [RESOLVED]

BansheeXYZ
Posts: 555
Joined: Fri Oct 23, 2015 8:19 pm

Build #135: Questgiver name doesn't match log [RESOLVED]

Post by BansheeXYZ »

SAVE4.zip
(240.47 KiB) Downloaded 88 times
This merchant in gem store's name is "Fheldka". In the quest log and in conversation with henchman (go sleep at inn for 8 hours to fight him), she is referred to as "Fheldon". Possibly a male/female name check issue?

Note that I started this quest in build #133.

User avatar
Interkarma
Posts: 7242
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #135: Questgiver name doesn't match log

Post by Interkarma »

Thanks for report. I have this in my internal bug tracker, but will use this thread to remind me to fix later. Cheers. :)

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Build #135: Questgiver name doesn't match log

Post by R.D. »

Note that I started this quest in build #133.
Name generation was recently changed to be closer to classic. If the name isn't saved as a string by the quest, but rather gets re-generated through the name creation function by a seed value or something, this would explain it, and I'd say this can be closed as it's just a temporary issue that won't happen for any new quests.

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Build #135: Questgiver name doesn't match log

Post by R.D. »

I'm not sure about the timing of the builds and how they match up to GitHub commits. So the quest was started in Build #133, and the report comes for Build #135. I don't know when those came out, but the commit that changed name generation was on Sept. 30 and would have been in the next live build released after that.

BansheeXYZ
Posts: 555
Joined: Fri Oct 23, 2015 8:19 pm

Re: Build #135: Questgiver name doesn't match log

Post by BansheeXYZ »

This is not fixed in #135 or 137. If you get a quest from a woman, the female name is logged as the male version. I just got a quest from Caarci, and it was logged as "Caarcin" and I must do stuff for "him". If it's an escort quest, and the escort is a woman, a man's face will appear in your status space.

User avatar
Interkarma
Posts: 7242
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #135: Questgiver name doesn't match log

Post by Interkarma »

Allofich, I believe this one is just related to gender of sprite not being injected to virtual questor at compile time. It's something I've been meaning to look at for a while, and have some ideas for approach.

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Build #135: Questgiver name doesn't match log

Post by R.D. »

Ah, okay, so it's not the issue I suspected then.

BansheeXYZ
Posts: 555
Joined: Fri Oct 23, 2015 8:19 pm

Re: Build #135: Questgiver name doesn't match log

Post by BansheeXYZ »

FYI, I just checked classic and it has its own issues with this stuff. For one, any time you ask for work, the person will give a name, and the following pronoun will always be he/him even if the name is female. i.e. look at this screenshot.

The other problem with classic is that you can find this person and... they don't offer the job, and then if you ask them for work, they say stuff about themselves and refer to themselves as a man. Weird.

Image

User avatar
Hazelnut
Posts: 3016
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build #135: Questgiver name doesn't match log

Post by Hazelnut »

Is this just because classic quest scripts don't both defining the gender of person resources properly?
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Interkarma
Posts: 7242
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #135: Questgiver name doesn't match log

Post by Interkarma »

Yep, there's just no system for keeping gender consistent between world and quests. A quest Person is technically a completely different virtual NPC to the one in the game world.

This gave me some grief early on when developing quest system until I realised it's a problem with classic design and just let it go for the time being. I have some ideas how to improve this, but won't give this priority for a while.

Locked