Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
-
- Posts: 64
- Joined: Tue Feb 06, 2018 6:06 am
Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
Not sure if this is a bug or not, but on my test character (imported from Classic) I came across this weird little oddity...
Not sure if you can see it clearly in the screenshot, but there's a skeleton corpse floating up there in the air to the southeast of the cemetery in Penbrugh.
Here's the location, I tried to get it exact on the map. Arrow is me standing directly underneath it.
Not sure if you can see it clearly in the screenshot, but there's a skeleton corpse floating up there in the air to the southeast of the cemetery in Penbrugh.
Here's the location, I tried to get it exact on the map. Arrow is me standing directly underneath it.
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh?
That's a new one. The corpse is almost certain left-over from somewhere else and not cleaned out of the scene correctly. I'm just not sure what conditions could have caused that yet.
Would you be able to provide a save game at the spot in your second screenshot with the error still present? Thank you.
Would you be able to provide a save game at the spot in your second screenshot with the error still present? Thank you.
-
- Posts: 64
- Joined: Tue Feb 06, 2018 6:06 am
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh?
Yeah, I'll get on that for you. Where are the save games located again?
EDIT: Sorry about my derpiness when it comes to this... I forgot that I'd fast-travelled away in that save, I just fast-travelled back to Penbrugh and went to the spot and the skele-corpse was no longer there. Weird.
EDIT: Sorry about my derpiness when it comes to this... I forgot that I'd fast-travelled away in that save, I just fast-travelled back to Penbrugh and went to the spot and the skele-corpse was no longer there. Weird.
- Interkarma
- Posts: 7247
- Joined: Sun Mar 22, 2015 1:51 am
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh?
There was some fixes to scene cleanup in recent versions that likely contributed to this. I'll mark as resolved for now as it can't be reproduced easily and is possibly already fixed.
- King of Worms
- Posts: 4753
- Joined: Mon Oct 17, 2016 11:18 pm
- Location: Scourg Barrow (CZ)
- Contact:
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
Hmm, I saw those as well. They appeared when I was resting outside, than my rest was interrupted cca 4 times during the night and I used "killall" commands immediately (like in RL )
Filthy, did u use "Killall" command as well before the skeleton appeared?
Filthy, did u use "Killall" command as well before the skeleton appeared?
DREAM Nexus https://www.nexusmods.com/users/73250038?tab=user+files
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
DREAM Forums viewtopic.php?f=27&t=1168
DISCORD: king_of_worms_cz
-
- Posts: 64
- Joined: Tue Feb 06, 2018 6:06 am
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
I honestly can't remember. I don't believe I did.
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
Traveling in the Alik'R desert with Tedious Travel, I have been interrupted by an unexpected Orc Warlord that I immediately pacified using my mastery of orc language.
Passing by him, I resumed my journey east until I met another Orc Warlord a bit above the ground. He landed as I approached, but was pacific already (no "you pacified an Orc Warlord using orc skill" message this time).
I passed by that second one, until I got interrupted by an Orc Warlord in the sky, that wouldn't come down.
Moving on, I was interrupted by an Orc Warlord in the sky...
Ok, that was the last one; but it seems this scene cleaning issue is still, or again, present.
I'm using several mods, including Distant Terrain 2.4.2, I wonder if modding could interfere with terrain cleanup in some way; Because I never managed to reproduce that issue without mods (but it could just be that it changes timing, or that I got lucky)
Passing by him, I resumed my journey east until I met another Orc Warlord a bit above the ground. He landed as I approached, but was pacific already (no "you pacified an Orc Warlord using orc skill" message this time).
I passed by that second one, until I got interrupted by an Orc Warlord in the sky, that wouldn't come down.
Moving on, I was interrupted by an Orc Warlord in the sky...
Ok, that was the last one; but it seems this scene cleaning issue is still, or again, present.
I'm using several mods, including Distant Terrain 2.4.2, I wonder if modding could interfere with terrain cleanup in some way; Because I never managed to reproduce that issue without mods (but it could just be that it changes timing, or that I got lucky)
- Attachments
-
- SAVE126.zip
- (212.52 KiB) Downloaded 76 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
Code: Select all
for (int i = 0; i < looseObjectsList.Count; i++)
{
if (!IsInRange(looseObjectsList[i].mapPixelX, looseObjectsList[i].mapPixelY) || collectAll)
{
if (looseObjectsList[i].gameObject != null)
{
looseObjectsList[i].gameObject.SetActive(false);
StartCoroutine(DestroyGameObjectIterative(looseObjectsList[i].gameObject));
}
looseObjectsList.RemoveAt(i);
}
}
If they're two consecutive loose objects to collect, that will skip the second one because RemoveAt() shifts all items above
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
Does seem to me like when an entry is removed the next one doesn't get checked and is skipped with that code. Well spotted.
Either the iteration for loop should be reversed so re-indexing on element removal only affects indexes of elements already checked, or the removeAll() method should be used with a predicate. Feel free to submit a PR mate.
Either the iteration for loop should be reversed so re-indexing on element removal only affects indexes of elements already checked, or the removeAll() method should be used with a predicate. Feel free to submit a PR mate.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Build #0.5.505: Weird floating skele-corpse in Penbrugh? [RESOLVED]
Done
I used the same style I've seen used in other places in the code
I used the same style I've seen used in other places in the code
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart