If you press the "use magic item" key with no item to activate, the mouse pointer appears but no dialog box, and you have to kill the game.
Seen on stream:
https://www.youtube.com/watch?v=-YoL0kf91_s&t=66
It's easy to reproduce, I'm not including game save.
Dev build/Linux: game freeze with "use magic item" key win no magic item [RESOLVED]
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Dev build/Linux: game freeze with "use magic item" key win no magic item [RESOLVED]
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
Hmm I should have tested that! Should be easy to fix.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
Nothing in the logs.
Classic Daggerfall behavior: do nothing.
But I think some scrolling message along the line of "you have no magic item to activate" should be better.
Classic Daggerfall behavior: do nothing.
But I think some scrolling message along the line of "you have no magic item to activate" should be better.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
Saw a freeze on another stream, I created a PR
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
-
- Posts: 555
- Joined: Fri Oct 23, 2015 8:19 pm
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
The message should probably be of the info type, like the "you have no spell book" message on recasting. Did you make it that way?
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
"Use magic item" does not refer to the spell book, it refers to all objects having "cast when used" effects, and potions.
So I used "You have no usable magic item" as middle screen message.
I don't know if you get some message if you try to cast a spell without a spellbook, you probably should, but that's a different issue.
PS If you have no spellbook and try to cast a spell you get "You have no spellbook!" already.
As a scroll text and not middle screen text, so there may be a consistency issue though
So I used "You have no usable magic item" as middle screen message.
I don't know if you get some message if you try to cast a spell without a spellbook, you probably should, but that's a different issue.
PS If you have no spellbook and try to cast a spell you get "You have no spellbook!" already.
As a scroll text and not middle screen text, so there may be a consistency issue though
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
-
- Posts: 555
- Joined: Fri Oct 23, 2015 8:19 pm
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
That's what I'm trying to convey. The message should appear at the top and fade out like similar errors or basic info messages. It shouldn't be a message box that pauses the game and needs a click-through.
Last edited by BansheeXYZ on Thu Jan 31, 2019 9:27 am, edited 1 time in total.
- pango
- Posts: 3359
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
That's neither, that's a mid screen message (like, say, lockpicking messages). It shows up something like 1.5s and disappearsBansheeXYZ wrote: ↑Thu Jan 31, 2019 9:23 am That's what I'm trying to convey. The message should appear at the top and fade out like similar errors. It shouldn't be a message box that pauses the game and needs a click-through.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
-
- Posts: 555
- Joined: Fri Oct 23, 2015 8:19 pm
Re: Dev build/Linux: game freeze with "use magic item" key win no magic item
Ok, then it should be a mid-screen message if that's what it's called.
If you're wondering when it's appropriate to use pause boxes, it's usually because there's a choice (Yes/No) or just a lot of stuff to read (An urchin slips a letter into your...).
Descriptions of things, time left at an inn, and failures generally don't pause the game because the ramifications of missing it are minimal, so it isn't worth the interruption.
If you're wondering when it's appropriate to use pause boxes, it's usually because there's a choice (Yes/No) or just a lot of stuff to read (An urchin slips a letter into your...).
Descriptions of things, time left at an inn, and failures generally don't pause the game because the ramifications of missing it are minimal, so it isn't worth the interruption.