Dev build/Linux: %loc not expanded (marked locaion confusion?) [RESOLVED]

Locked
User avatar
pango
Posts: 3357
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Dev build/Linux: %loc not expanded (marked locaion confusion?) [RESOLVED]

Post by pango »

When asking for a quest's NPC location, town people may mark the location on the map but are unable to use the marked location's name in the conversation, as in
"Beggin' yer pardon XXX, but most folk know this. is west of where we're standing"
"Always glad ta help you, XXX. is a ways east of here"
loc not expanded.jpg
loc not expanded.jpg (283.46 KiB) Viewed 1529 times
PS: It doesn't seem consistent; It worked when I asked for the location of the quest giver
Attachments
SAVE1.zip
(416.32 KiB) Downloaded 89 times
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Dev build/Linux: %loc not expanded (marked locaion confusion?)

Post by Nystul »

where is->location works a bit differently than where is->person
last one has a problem with %loc macro, yes.
the location name should be expanded with %loc macro - will take a look

but regarding just the general direction without map reveal, like (XXX being the pc name here):
pango wrote: Sat Dec 15, 2018 6:49 am "Always glad ta help you, XXX. is a ways east of here"
Vanilla expands this in just the same way without either the person nor the location name

edit: I just tested in dfunity and it seems to work fine for me:
Image

could you please countercheck?

User avatar
Hazelnut
Posts: 3016
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: %loc not expanded (marked locaion confusion?)

Post by Hazelnut »

Closing this as unable to reproduce if no one gives more info in next day or two.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Dev build/Linux: %loc not expanded (marked locaion confusion?)

Post by Nystul »

I think I know now after watching some of Steep's videos (https://www.youtube.com/playlist?list=P ... 1AosypKQ_D)
It does not work correctly for Residences (all other building types resolve correctly to their name)

I think this is a regression bug since I am pretty sure this worked already some time ago
Will take a look when I have some time

User avatar
Nystul
Posts: 1501
Joined: Mon Mar 23, 2015 8:31 am

Re: Dev build/Linux: %loc not expanded (marked locaion confusion?)

Post by Nystul »

pr is issued solving this bug

Locked