Dev build/Linux: magic item shops restocking do not match classic [PARTIALLY RESOLVED]

Curated user bug reports with enough information to reproduce issue. Moderators will move topics here from Help & Support once a bug is confirmed and enough information has been provided.
User avatar
pango
Posts: 1417
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Dev build/Linux: magic item shops restocking do not match classic [PARTIALLY RESOLVED]

Post by pango » Tue Oct 23, 2018 6:08 am

Currently, each time you open up a magic items shop, you're facing a new set of items. From memory and quick test, in classic those behave more like your usual shop: items will stay around for a while, if you buy one it disappears from the shop (but the shop will eventually refill).

But also, again from memory, the same merchant will always have the same set of items on display. That's consistent with people starting to build list of places to buy specific items, even if the UESP contains inaccuracies at times.
(another example in Province Gazetteer)
I wonder if that has been fully reverse-engineered.
Attachments
SAVE77.zip
In front of a random magic merchant
(186.08 KiB) Downloaded 37 times
Last edited by pango on Fri Nov 02, 2018 8:07 am, edited 1 time in total.
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Hazelnut
Posts: 1501
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by Hazelnut » Tue Oct 23, 2018 8:20 am

Yeah this is a placeholder implementation only, to be redone when we've figured out the way classic works.

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by R.D. » Tue Oct 23, 2018 10:15 am

I updated the type of items that are created a while ago to generally match classic (not counting this apparently always producing the same specific items, which I didn't know about), so it's not just a placeholder, although, the items not persisting between different talks to the merchant would mean that part hasn't been implemented yet.

If merchants really always have the same stock in classic, then my first guess is that the random number generator always ends up with the same specific seed for that merchant, resulting in the same items. Not sure if we will have that replicated any time soon, it would probably be the same thing as, or related to at least, getting interior NPC names to match classic.

User avatar
Hazelnut
Posts: 1501
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by Hazelnut » Tue Oct 23, 2018 12:24 pm

Allofich, I meant that it was a placeholder that a new list of items is generated each time. I added a comment about that in PR #883:

Code: Select all

        // TODO: Classic seems deterministic so when re-visiting each mages guildhall, player sees same stuff.
        // Does it change with level? Is it always generated but uses a consistent seed? How should DFU do this?
I think you're right that it will use something to seed the creation function. Currently all of the random item generation methods are using unity random functions instead of the daggerfall classic rand so that's also an issue here.

User avatar
Interkarma
Posts: 4838
Joined: Sun Mar 22, 2015 1:51 am

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by Interkarma » Tue Oct 23, 2018 12:58 pm

This feature is functional and free of operational defects for end users. It might not match classic behaviour precisely, but that's more a topic of refinement than a bug. I have no concerns about small divergences such as this.

Happy for discussion to continue, but I don't see this as a priority right now. :)

User avatar
Hazelnut
Posts: 1501
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by Hazelnut » Tue Oct 23, 2018 1:34 pm

Completely agree, hence why I just put the TODO comment in a month ago and left it at that. :)

User avatar
pango
Posts: 1417
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by pango » Tue Oct 23, 2018 2:57 pm

As far as I'm concerned, I like the idea of stock being deterministic for gameplay (this gives an incentive to explore mages guilds to find the specific item you want, take notes, share findings with other players).
Matching the exact formula used in classic so that you find the same items in both games would be nice, but I really don't mind as much.
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 1417
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by pango » Mon Feb 04, 2019 8:41 pm

Cheesing magic items merchant refill for profit :D
Just reroll the stock until you find trinkets to boost all your abilities:
https://www.youtube.com/watch?v=mzsNBH_AYD8&t=5049
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Hazelnut
Posts: 1501
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Dev build/Linux: magic item shops restocking do not match classic

Post by Hazelnut » Mon Feb 04, 2019 9:55 pm

Hey, you could use your time to figure out the classic algorithm instead! :lol:

User avatar
jayhova
Posts: 589
Joined: Wed Jul 19, 2017 7:54 pm
Contact:

theJF - Daggerfall Unity (w/Mods) Part 5 (video)

Post by jayhova » Tue May 21, 2019 2:40 am

mages guild inventory refreshes each time.

[youtube]https://youtu.be/lwenm-Q-17Q?t=866[/youtube]
Remember always 'What would Julian Do?'.
Windows 10 Pro 64 bit. DFU Ver. Alpha 0.10.7

Post Reply