That's perfect thanks, I tested with your changes and still works when I override what I need to.Hazelnut wrote: ↑Thu Mar 25, 2021 5:56 pm Hi there, before I submit the PR could you check here and review the changes I've made:
https://github.com/Interkarma/daggerfal ... e?expand=1
Have I missed anything that you need?
Does it still work properly?
(I have not tested the changes)
As soon as you say you're happy I will submit the PR.
[MOD] Convenient Quest Log
- Macadaynu
- Posts: 264
- Joined: Sun Mar 07, 2021 1:18 pm
Re: Convenient Quest Log
- Macadaynu
- Posts: 264
- Joined: Sun Mar 07, 2021 1:18 pm
Re: Convenient Quest Log
In terms of the location I'm using existing functionality, whereby if a quest message has a location you can click on it and travel there. As I'm now grouping many messages to one quest, I decided to use the location for the latest message for that quest (if it has a location).imsobadatnicknames wrote: ↑Thu Mar 25, 2021 7:36 pm Really cool that someone finally figured out how to do something like this, this is brilliant.
Quick question, though, how does the mod pick which timer and location to display? Afaik there are some quests that involve different timers for different events, and some where you have to go to several places.
For the timers, I decided to go with the timer with the least time remaining for the selected quest.
There are obviously different ways this could be handled, and in future I may add some config options to handle this differently, but that's how it works as it stands. (I didn't want to put too much info on the main active quests page, as that's the problem I'm trying to solve!)
Thanks for the feedback
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: Convenient Quest Log
Great, I will submit the changes then.
Is your mod code available on github somewhere? If it is I am happy to give it a quick look to see if I have any suggestions.
Is your mod code available on github somewhere? If it is I am happy to give it a quick look to see if I have any suggestions.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- Macadaynu
- Posts: 264
- Joined: Sun Mar 07, 2021 1:18 pm
Re: Convenient Quest Log
That'd be great thanks, I'll get my code up on github tomorrow.
- Macadaynu
- Posts: 264
- Joined: Sun Mar 07, 2021 1:18 pm
Re: Convenient Quest Log
Hi Hazelnut, I've uploaded the mod to Github now:
https://github.com/Macadaynu/unity/blob ... gWindow.cs
I found a small issue when testing this morning with the `Dialog Notes` button, in that if you keep pressing it to cycle back around to Active Quests, it will display the quests in the standard manner unless you then scroll up/down. I think it can be easily fixed with an override to `DialogButton_OnMouseClick` if that's possible. I've put the suggested fix in a comment on line 122.
Let me know if you need anything else, cheers
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: Convenient Quest Log
Okay, made all the event handler methods overridable too.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- Macadaynu
- Posts: 264
- Joined: Sun Mar 07, 2021 1:18 pm
Re: Convenient Quest Log
That's awesome cheers,
I've un-commented that method from my github file, so I'll get a release sorted as soon as your PR gets merged in
I've un-commented that method from my github file, so I'll get a release sorted as soon as your PR gets merged in
- Hazelnut
- Posts: 3016
- Joined: Sat Aug 26, 2017 2:46 pm
- Contact:
Re: Convenient Quest Log
You will need to wait for the next release of DFU as well before you can release to the public.
Thanks for your patience.
Thanks for your patience.
See my mod code for examples of how to change various aspects of DFU: https://github.com/ajrb/dfunity-mods
- Macadaynu
- Posts: 264
- Joined: Sun Mar 07, 2021 1:18 pm
Re: Convenient Quest Log
Daggerfall 0.11.3 has now been released with the changes I require to release this mod. I'm a bit busy with real life stuff at the moment, but I'll look at getting this mod out to the public as soon as I have some free time.