Adjusting Interior Ambient Lights

Discuss coding questions, pull requests, and implementation details.
Post Reply
User avatar
Ralzar
Posts: 2109
Joined: Mon Oct 07, 2019 4:11 pm
Location: Norway

Adjusting Interior Ambient Lights

Post by Ralzar »

Figured I would just throw the discussion out here instead of trying to make a PR without discussing it first.
At the moment it is possible to adjust ambient light for "night" and "dungeon" respectively in the DFU advanced settings. Which is great for making a more spooky and realistic atmosphere.

However, there is no slider for ambient lights in house interiors. This can be pretty easily manipulated in a mod, but it just feels really weird for there to be separate sliders to adjust night and dungeon lights while houses have no setting.

So I was wondering if it would be a good idea to either add another slider for house interiors or alternatively simply rename the dungeon slider to "Interior Ambient Light" and use that value as a multiplier on the house interior light the same way it is currently used on dungeon light.

https://github.com/Interkarma/daggerfal ... ght.cs#L69

Simply renaming the slider and doing this for example:

Code: Select all

if (DaggerfallUnity.Instance.WorldTime.Now.IsNight)
    targetAmbientLight = (DaggerfallUnity.Settings.AmbientLitInteriors) ? InteriorNightAmbientLight_AmbientOnly : InteriorNightAmbientLight * DaggerfallUnity.Settings.DungeonAmbientLightScale;
else
     targetAmbientLight = (DaggerfallUnity.Settings.AmbientLitInteriors) ? InteriorAmbientLight_AmbientOnly : InteriorAmbientLight * DaggerfallUnity.Settings.DungeonAmbientLightScale;

User avatar
BadLuckBurt
Posts: 780
Joined: Sun Nov 05, 2017 8:30 pm

Re: Adjusting Interior Ambient Lights

Post by BadLuckBurt »

I agree. My vote goes to adding an extra slider for Interior light scale for the simple reason that one might want darker dungeons and brighter interiors or vice versa.
Daggerfall Unity on UESP: https://en.uesp.net/w/index.php?title=T ... fall_Unity
Daggerfall Unity on Nexus Mods: https://www.nexusmods.com/daggerfallunity
My github repositories with mostly DFU related stuff: https://github.com/BadLuckBurt

User avatar
King of Worms
Posts: 4432
Joined: Mon Oct 17, 2016 11:18 pm
Location: Scourg Barrow (CZ)
Contact:

Re: Adjusting Interior Ambient Lights

Post by King of Worms »

Seems like a good idea, agree with BadLuckBurt on the slider. I use mod to adjust interior lights, but ppl should be able to do so in a vanilla as well IMO, esp when there already are sliders for dungeons and night.

User avatar
Ralzar
Posts: 2109
Joined: Mon Oct 07, 2019 4:11 pm
Location: Norway

Re: Adjusting Interior Ambient Lights

Post by Ralzar »

Until this gets looked at and hopefully added to DFU in some form, I have made a feature in Darker Dungeons where it sets house interior lighting to be a slightly brighter version of your DFU Dungeon Ambient Light Setting. +0.1 at night and +0.3 during day.

Code: Select all

private static void AdjustAmbientLight(PlayerEnterExit.TransitionEventArgs args)
{
	PlayerAmbientLight ambientLights = (PlayerAmbientLight)FindObjectOfType(typeof(PlayerAmbientLight));
	ambientLights.InteriorNightAmbientLight = ambientLights.InteriorAmbientLight * (Mathf.Min(1.0f, DaggerfallUnity.Settings.DungeonAmbientLightScale + 0.1f));
	ambientLights.InteriorAmbientLight = ambientLights.InteriorAmbientLight * (Mathf.Min(1.0f, DaggerfallUnity.Settings.DungeonAmbientLightScale + 0.3f));
}

Post Reply