0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Moderators will move topics here from Help & Support once an issue has been confirmed and enough information provided to reproduce.
Post Reply
Lywzc
Posts: 91
Joined: Mon Sep 23, 2019 6:15 pm

0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Post by Lywzc »

Doing Hunt for a Spriggan. I agreed to spriggan's request and it pointed me to a town. However asking for the person in the town yields nothing despite they said they marked the residence on my map. I even manually searched for the residence without success.
SAVE2.zip
(289.54 KiB) Downloaded 8 times
Here is the save file.

User avatar
Interkarma
Posts: 6847
Joined: Sun Mar 22, 2015 1:51 am

Re: No quest building at destination town.

Post by Interkarma »

The woodsman is present in the Hawking Residence. I located using quest debugger and was able to complete from quest there.

woodsman.JPG
woodsman.JPG (181.51 KiB) Viewed 294 times

I can see the building isn't being marked by NPCs in discovery data as you describe though. I'll do a run through of the quest without mods and see if I can reproduce.

User avatar
pango
Posts: 3129
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: No quest building at destination town.

Post by pango »

[Ninja'd by the master ninja ;) I used almost only cosmetic mods, so there's that.]

I confirm commoners do not manage to mark the location of the residence on the map
dialog-map.jpg
dialog-map.jpg (408.34 KiB) Viewed 293 times
However you can find it by triangulation, and the NPC is there
house-quest target.jpg
house-quest target.jpg (369.61 KiB) Viewed 293 times
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Interkarma
Posts: 6847
Joined: Sun Mar 22, 2015 1:51 am

Re: 0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Post by Interkarma »

Thanks Pango! :D

I just played through without any mods and can also confirm building is only discoverable through quest debugger. I'll move this one over to issues for follow-up later.

Adding notes for future self: discovery fails in DiscoverBuilding() as IsBuildingQuestResource() returns pcLearnedAboutExistence=false. This blocks setting override name so it appears on map. Even when an NPC marks on map first attempt, questInfo.resourceInfo[key].availableForDialog is false in IsBuildingQuestResource() which is why pcLearnedAboutExistence is also false. Possibly an issue with quest script or problem with AddDialog setup.

Lywzc
Posts: 91
Joined: Mon Sep 23, 2019 6:15 pm

Re: 0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Post by Lywzc »

Interkarma wrote: Sun May 22, 2022 9:35 pm Thanks Pango! :D

I just played through without any mods and can also confirm building is only discoverable through quest debugger. I'll move this one over to issues for follow-up later.

Adding notes for future self: discovery fails in DiscoverBuilding() as IsBuildingQuestResource() returns pcLearnedAboutExistence=false. This blocks setting override name so it appears on map. Even when an NPC marks on map first attempt, questInfo.resourceInfo[key].availableForDialog is false in IsBuildingQuestResource() which is why pcLearnedAboutExistence is also false. Possibly an issue with quest script or problem with AddDialog setup.
So I am just bad at finding it. Sad since I searched it for like half an hour.

Lywzc
Posts: 91
Joined: Mon Sep 23, 2019 6:15 pm

Re: 0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Post by Lywzc »

It seems marking residence by asking for a person rather than a general place is broken. I encountered this issue again on "Taking on the Thieves Guild" which requires asking for person.

User avatar
Jay_H
Posts: 3841
Joined: Tue Aug 25, 2015 1:54 am
Contact:

Re: 0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Post by Jay_H »

Let's keep this to one quest at a time, just in case the issue is different there. If you want to open a new topic for Taking on the Thieves Guild, we can take a closer look there.

User avatar
Ferital
Posts: 280
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Post by Ferital »

As Interkarma spotted, this is a bug from TalkManager. I think my old PR #2198 does fix it among other things, but I still have to finish it properly.

User avatar
Interkarma
Posts: 6847
Joined: Sun Mar 22, 2015 1:51 am

Re: 0.13.5 [M0B40Y05] - Hunt for a Spriggan, Woodsman building not properly marked on automap

Post by Interkarma »

Thanks Ferital. I'll take a look at your fix and might crib this by itself. No rush on your PR, whenever you feel it's ready. :)

Post Reply