Translated quest uses wrong %gXX marcos

Moderators will move topics here from Help & Support once an issue has been confirmed and enough information provided to reproduce.
Post Reply
User avatar
Jagget
Posts: 124
Joined: Fri Oct 06, 2023 12:28 am

Translated quest uses wrong %gXX marcos

Post by Jagget »

Quest: N0B11Y18
NPC: Person _rebel_ named Baltham_Greyman


Original quest text:
\DaggerfallUnity_Data\StreamingAssets\Quests\N0B11Y18.txt

Code: Select all

AcceptQuest:  [1002]
<ce>               Very good. There is a rebel mage that we
<ce>                need eliminated, by the name of _rebel_.
<ce>              A former pupil of mine, showed some promise
<ce>            but lacked the loyalty to the ancient principles
<ce>               of the Guild that are so important to its
<ce>               continued survival.  We have learned that
<ce>            %g is currently doing some kind of unsanctioned
<ce>               research over in ___rebelhouse_, apparently
<ce>            oblivious to %g3 danger.  You have =qtime_ days
<ce>            to dispose of this menace and report back to me.

Result in game:
Screenshot 2024-01-01 123053.png
Screenshot 2024-01-01 123053.png (716.31 KiB) Viewed 5386 times

Translated text:
\DaggerfallUnity_Data\StreamingAssets\Text\Quests\N0B11Y18-LOC.txt

Code: Select all

AcceptQuest:  [1002]
<ce> Отлично. Теперь к делу. Один маг по имени
<ce> _rebel_ поднимает мятеж против нас, и, пока
<ce> это все еще в стадии начала, нам необходимо
<ce> убрать %g4. Мой добрый ученик показывал большие
<ce> способности, но древние законы Гильдии оказались
<ce> %g2 не по плечу. К сожалению именно они есть
<ce> основа всей жизни Гильдии и без них нельзя обойтись.
<ce> Нам удалось узнать, что %g сейчас проводит какие-то
<ce> исследования, суть которых нам очень не нравится.
<ce> Через =qtime_ дней они будут закончены.
<ce> лаборатория называется __rebelhouse_. Ступайте туда
<ce> и постарайтесь устранить эту угрозу.

Result in game:
Screenshot 2024-01-01 123829.png
Screenshot 2024-01-01 123829.png (795.95 KiB) Viewed 5386 times
Daggerfall Russian Translation

User avatar
Interkarma
Posts: 7251
Joined: Sun Mar 22, 2015 1:51 am

Re: Translated quest uses wrong %gXX marcos

Post by Interkarma »

I note N0B11Y18 does not specify gender for Baltham in Person allocation.

Code: Select all

Person _rebel_ named Baltham_Greyman
This means the Person can be randomly male/female. This is nothing to do with localization, it's just that the quest system doesn't know or care which gender to use until it's specified. Changing to below will fix this in core.

Code: Select all

Person _rebel_ named Baltham_Greyman gender male
I'm assuming you left the pronoun macros untranslated to make the problem obvious to non Russian readers? Other than the gender selection in quest, is there actually anything wrong the macros here if the NPC was expected to be female?

User avatar
Jagget
Posts: 124
Joined: Fri Oct 06, 2023 12:28 am

Re: Translated quest uses wrong %gXX marcos

Post by Jagget »

Interkarma wrote: Mon Jan 01, 2024 9:14 pm This means the Person can be randomly male/female. This is nothing to do with localization, it's just that the quest system doesn't know or care which gender to use until it's specified. Changing to below will fix this in core.

Code: Select all

Person _rebel_ named Baltham_Greyman gender male
Yes, that would actually be the best solution
Interkarma wrote: Mon Jan 01, 2024 9:14 pm I'm assuming you left the pronoun macros untranslated to make the problem obvious to non Russian readers?
Correct.
Interkarma wrote: Mon Jan 01, 2024 9:14 pm Other than the gender selection in quest, is there actually anything wrong the macros here if the NPC was expected to be female?
None. The NPC generated have male appearance and the same face across several quest runs.

Bottom line, it's not a bug, it's a feature, lol :lol:

Thank you for your help!
Daggerfall Russian Translation

User avatar
Interkarma
Posts: 7251
Joined: Sun Mar 22, 2015 1:51 am

Re: Translated quest uses wrong %gXX marcos

Post by Interkarma »

I've plugged in that change as it's so simple. In the short term, you could probably hardcode those pronouns for Baltham as he is canonically male in these quests.

User avatar
Jagget
Posts: 124
Joined: Fri Oct 06, 2023 12:28 am

Re: Translated quest uses wrong %gXX marcos

Post by Jagget »

Interkarma wrote: Mon Jan 01, 2024 10:01 pm I've plugged in that change as it's so simple. In the short term, you could probably hardcode those pronouns for Baltham as he is canonically male in these quests.
Yes, we can always do both :D
Daggerfall Russian Translation

User avatar
Interkarma
Posts: 7251
Joined: Sun Mar 22, 2015 1:51 am

Re: Translated quest uses wrong %gXX marcos

Post by Interkarma »

After a bit of discussion on git, it seems there's something else going on. The macro is generating different results based on localization.

I'll revert that previous simple change as it doesn't appear to be adequate, and move this into issues for future.

Post Reply