Page 11 of 14
Re: [DFUnity] Russian translation
Posted: Tue Oct 31, 2023 8:09 pm
by Jagget
Interkarma wrote: ↑Thu Oct 19, 2023 9:34 pm
upcoming 0.16.2 release.
I'm partially glad that you didn't release it yet because I found one more thing that looks suspicious to me.
%g2 and
%g3 are the same for female actors.
Here are screens with quest text:
Code: Select all
_male_ %g1 %g2 %g3 %g2self
_female_ %g1 %g2 %g3 %g2self
_male_ %g1 %g2 %g3 %g2self
_female_ %g1 %g2 %g3 %g2self
Strings:
Code: Select all
pronounHe,он
pronounShe,она
pronounHim,ему
pronounHer,ей
pronounHis,его
pronounHers,её
pronounHimself,сам
pronounHerself,сама
And how it looks in the game. I believe
%g3 should be
"pronounHers" for female, but currently it is
"pronounHer"
Also, as you can see, it is correct for male actor.
Re: [DFUnity] Russian translation
Posted: Tue Oct 31, 2023 8:31 pm
by Jagget
Jagget wrote: ↑Tue Oct 31, 2023 8:09 pm
And how it looks in the game. I believe
%g3 should be
"pronounHers" for female, but currently it is
"pronounHer"
Also, as you can see, it is correct for male actor.
I think I have found the error.
/Assets/Scripts/Game/Questing/QuestMCP.cs line 125
and
/Assets/Scripts/Game/TalkManagerMCP.cs line line 180
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 12:12 am
by Interkarma
I agree with you it should probably work the way you say. In fact, it's how we had it set back in the early days of development. But if you
search through the default English quests, you'll note that %g3 is used for "her" in all cases. Changing this to "hers" will break the exported quests as written.
As with a lot of things in DFU, the behaviour is determined by the expected outcome in English. Daggerfall's data is very inconsistent and messy for these kinds of things, which a constant source of frustration for everyone, especially me.
Stepping back and looking for another solution, is "pronounHers" currently not accessible using another macro? Short of changing macro and updating all the quests, could a new macro serve to access this string for translated quests?
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 12:16 am
by Jagget
Interkarma wrote: ↑Wed Nov 01, 2023 12:12 am
I agree with you it should probably work the way you say. In fact, it's how we had it set back in the early days of development. But if you
search through the default English quests, you'll note that %g3 is used for "her" in all cases. Changing this to "hers" will break the exported quests as written.
As with a lot of things in DFU, the behaviour is determined by the expected outcome in English. Daggerfall's data is very inconsistent and messy for these kinds of things, which a constant source of frustration for everyone, especially me.
Stepping back and looking for another solution, is "pronounHers" currently not accessible using another macro? Short of changing macro and updating all the quests, could a new macro serve to access this string for translated quests?
pronounHers is not available.
could a new macro serve to access this string for translated quests?
Yes, I can live with that and adjust the translation.
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 12:24 am
by Jagget
While we at it, can we add 5 options for Male and 3 options for Female?
P.S. Just kidding. At least we need an alternative to
pronounHer
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 12:32 am
by Interkarma
Yeah, the way DF text handles text expansion is super basic and doesn't always map well into other languages. Augmenting the expanding macros with a whole system of programmable smart strings would be awesome, but that's getting well beyond my pay grade.
OK, we already have
%g3 for
his/her. I'll quickly add a
%g4 for
his/hers as well. Hopefully that's good enough to work with for now.
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 12:35 am
by Jagget
Interkarma wrote: ↑Wed Nov 01, 2023 12:32 am
OK, we already have
%g3 for
his/her. I'll quickly add a
%g4 for
his/hers as well. Hopefully that's good enough to work with for now.
Thank you very much! I'll run quick regex replacement %g3 -> %g4! Yeah!
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 12:42 am
by Interkarma
You're welcome. I've added that change now.
https://github.com/Interkarma/daggerfal ... 30efa4b266
Edit: BTW, the commit comment is misleading for that one. It should say "Add %g4 for missing pronoun His/Hers" (not %pg4). The code is fine, just the description is incorrect.
To recap,
%g3="his/her" and
%g4="his/hers".
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 12:57 am
by Jagget
Interkarma wrote: ↑Wed Nov 01, 2023 12:42 am
To recap,
%g3="his/her" and
%g4="his/hers".
Yeah. I get that. Now we don't need
%g3 at all. I mean, in translation. And can safely replace with
%g4.
So the full working set is
%g (or %g1), %g2, %g4
Re: [DFUnity] Russian translation
Posted: Wed Nov 01, 2023 1:18 am
by Jagget
Interkarma wrote: ↑Wed Nov 01, 2023 12:42 am
You're welcome. I've added that change now.
And now I need 0.16.2 as never before
