Build #122 - One of the repair messages showing "%pct[srcDataUnknown]" instead of name. [RESOLVED]

User avatar
Interkarma
Posts: 3600
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #122 - One of the repair messages showing "%pct[srcDataUnknown]" instead of name.

Post by Interkarma » Thu Jun 28, 2018 8:59 am

I'm interested in how classic handles text ID 260 variants in shops, especially when player is guildless. Does it simply skip that text variant, use a generic fallback title, or substitute with something else entirely like %hon. Will need to test this in classic.

I'm assuming this has been an issue with %pct from the start, this is just the first time someone has noticed. It's a fairly minor issue though, and several easy approaches to fixing it. :)

User avatar
Peepo
Posts: 15
Joined: Tue Jun 26, 2018 7:46 pm

Re: Build #122 - One of the repair messages showing "%pct[srcDataUnknown]" instead of name.

Post by Peepo » Thu Jun 28, 2018 4:45 pm

Is it possible that the problem is caused because the merchant tries to give me a discount as good as a guild discount and pulls from that pool of messages? As if the % of discount itself is directly linked to the pool of messages, and not the npc affiliation.

User avatar
Interkarma
Posts: 3600
Joined: Sun Mar 22, 2015 1:51 am

Re: Build #122 - One of the repair messages showing "%pct[srcDataUnknown]" instead of name.

Post by Interkarma » Thu Jun 28, 2018 9:12 pm

It's OK, the problem is well understood. We're just discussing approaches to fix. Thank you for the report. :)

User avatar
Hazelnut
Posts: 926
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build #122 - One of the repair messages showing "%pct[srcDataUnknown]" instead of name.

Post by Hazelnut » Fri Jul 13, 2018 9:06 pm

Fixed this now, needed a context handler added in the trade window. Took me a quite a while (~1 hour) to go though all the different bits cos I am rusty. I also had to check that classic actually used these messages for merchant repair services. (turns out Allofich was spot on with that logic transcription job as usual)

Thanks for both bug reports Peepo, excellent & helpful reporting there my friend!

User avatar
Hazelnut
Posts: 926
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Build #122 - One of the repair messages showing "%pct[srcDataUnknown]" instead of name.

Post by Hazelnut » Fri Sep 28, 2018 8:29 pm

I have fixed this by enabling all contextual macros to have a non-contextual fall back. This is the only macro that does at the moment (if no guild context it's replaced with pc name instead of pc guild rank title) but there may be more so keep a lookout. Would be good to find another since I implemented a general way to handle rather than doing a special case... which if this is the only one would have been more appropriate.

Go find 'em DFU test community! (now why is the flying monkey scene from Wiz of Oz popping into my head...) :lol:

Post Reply