Invisible grid in ground textures in cities
- Gravitus
- Posts: 26
- Joined: Thu Jun 25, 2020 3:42 pm
Re: Invisible grid in ground textures in cities
I too have lines like these (but much less noticeable). I also get these tiled lines across the screen when playing the spellcasting animation. Running the game with a R9 270X.
- pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Invisible grid in ground textures in cities
I found this page interesting:
https://forum.unity.com/threads/tiling- ... ts.535793/
https://forum.unity.com/threads/tiling- ... ts.535793/
- the way to compute mipmap level is slightly different, but I guess the way used in DFU is not wrong;
- they seem to agree that it needs some "padding" to tile local coordinates; something we could experiment with (basically declaring that what looked like a hack is in fact legit)
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Invisible grid in ground textures in cities
I created a PR, but this is only experimental at this point, as I can't test its effectiveness myself.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Magicono43
- Posts: 1141
- Joined: Tue Nov 06, 2018 7:06 am
Re: Invisible grid in ground textures in cities
Made a comment on that PR, but I'll just copy it here too.
"I just tested your changes on my system through changing the lines in that file for my Unity Editor version of DFU 0.13.5. So this test was not in the compiled version just the Unity Editor environment.
So at least on my side through the editor by changing the shader file directly the seams appear to still be there."
- pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Invisible grid in ground textures in cities
Thanks for testing. Are seams as marked as before? (Looking at the screenshots I see no obvious difference...)
I left the _Padding value at 0.0005 just like in the aforementioned forum, but I don't know if there's an optimal value...
I left the _Padding value at 0.0005 just like in the aforementioned forum, but I don't know if there's an optimal value...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Magicono43
- Posts: 1141
- Joined: Tue Nov 06, 2018 7:06 am
Re: Invisible grid in ground textures in cities
Hmm, I'd say they seemed about the same? But I was not really checking for if they were better at the time more if they were just gone entirely. But at least from the setting in that test with those values they seemed basically the same, but maybe there was an improvement by a few pixels that I just did not really notice.
- pango
- Posts: 3358
- Joined: Wed Jul 18, 2018 6:14 pm
- Location: France
- Contact:
Re: Invisible grid in ground textures in cities
I managed to reproduce the issue with a Intel integrated graphics, and updated my PR on Github...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart
- Magicono43
- Posts: 1141
- Joined: Tue Nov 06, 2018 7:06 am
- Magicono43
- Posts: 1141
- Joined: Tue Nov 06, 2018 7:06 am