Invisible grid in ground textures in cities

Post here if you need help getting started with Daggerfall Unity or just want to clarify a potential bug. Questions about playing or modding classic Daggerfall should be posted to Community.
User avatar
Gravitus
Posts: 26
Joined: Thu Jun 25, 2020 3:42 pm

Re: Invisible grid in ground textures in cities

Post by Gravitus »

I too have lines like these (but much less noticeable). I also get these tiled lines across the screen when playing the spellcasting animation. Running the game with a R9 270X.

User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Invisible grid in ground textures in cities

Post by pango »

I found this page interesting:
https://forum.unity.com/threads/tiling- ... ts.535793/
  • the way to compute mipmap level is slightly different, but I guess the way used in DFU is not wrong;
  • they seem to agree that it needs some "padding" to tile local coordinates; something we could experiment with (basically declaring that what looked like a hack is in fact legit)
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Invisible grid in ground textures in cities

Post by pango »

I created a PR, but this is only experimental at this point, as I can't test its effectiveness myself.
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Magicono43
Posts: 1141
Joined: Tue Nov 06, 2018 7:06 am

Re: Invisible grid in ground textures in cities

Post by Magicono43 »

pango wrote: Mon Apr 25, 2022 1:08 am I created a PR, but this is only experimental at this point, as I can't test its effectiveness myself.
Made a comment on that PR, but I'll just copy it here too.

"I just tested your changes on my system through changing the lines in that file for my Unity Editor version of DFU 0.13.5. So this test was not in the compiled version just the Unity Editor environment.
System Specs shown from Player.log
System Specs shown from Player.log
Apparent_System_Specs.PNG (40.44 KiB) Viewed 666 times
Example of seams before putting your changes.
Example of seams before putting your changes.
Unchanged File.jpg (89.51 KiB) Viewed 666 times
Example of seams after putting your changes, also exited and entered a nearby building to make sure there was not anything sticking from loading the save or whatever.
Example of seams after putting your changes, also exited and entered a nearby building to make sure there was not anything sticking from loading the save or whatever.
Changed File.jpg (90.14 KiB) Viewed 666 times
So at least on my side through the editor by changing the shader file directly the seams appear to still be there."

User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Invisible grid in ground textures in cities

Post by pango »

Thanks for testing. Are seams as marked as before? (Looking at the screenshots I see no obvious difference...)
I left the _Padding value at 0.0005 just like in the aforementioned forum, but I don't know if there's an optimal value...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Magicono43
Posts: 1141
Joined: Tue Nov 06, 2018 7:06 am

Re: Invisible grid in ground textures in cities

Post by Magicono43 »

pango wrote: Mon Apr 25, 2022 9:36 pm Thanks for testing. Are seams as marked as before? I left the _Padding value at 0.0005 just like in the aforementioned forum, but I don't know if there's an optimal value...
Hmm, I'd say they seemed about the same? But I was not really checking for if they were better at the time more if they were just gone entirely. But at least from the setting in that test with those values they seemed basically the same, but maybe there was an improvement by a few pixels that I just did not really notice.

User avatar
pango
Posts: 3358
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: Invisible grid in ground textures in cities

Post by pango »

I managed to reproduce the issue with a Intel integrated graphics, and updated my PR on Github...
Mastodon: @pango@fosstodon.org
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Magicono43
Posts: 1141
Joined: Tue Nov 06, 2018 7:06 am

Re: Invisible grid in ground textures in cities

Post by Magicono43 »

pango wrote: Fri Apr 29, 2022 10:37 pm I managed to reproduce the issue with a Intel integrated graphics, and updated my PR on Github...
Here is my results after testing with your new commit.
Without 1
Without 1
2022_04_29_18_54_39.jpg (119.42 KiB) Viewed 604 times
With 1
With 1
2022_04_29_18_53_25.jpg (115.8 KiB) Viewed 604 times

User avatar
Magicono43
Posts: 1141
Joined: Tue Nov 06, 2018 7:06 am

Re: Invisible grid in ground textures in cities

Post by Magicono43 »

Without 2
Without 2
2022_04_29_18_46_18.jpg (89.39 KiB) Viewed 603 times
With 2
With 2
2022_04_29_18_45_07.jpg (86.98 KiB) Viewed 603 times

Post Reply