0.7.65: wrong ruler in "Any news" [RESOLVED]

User avatar
Ferital
Posts: 95
Joined: Thu Apr 05, 2018 8:01 am

0.7.65: wrong ruler in "Any news" [RESOLVED]

Post by Ferital » Mon Mar 11, 2019 3:23 pm

When asking an NPC for any news, you can sometimes get information about a random new ruler of a random kindgom. But from what I remember in Classic, kindgoms with their ruler set in Factions.txt (Daggerfall, Sentinel, Wayrest, Anticlere, Lainlyn...) would use this one instead of generating a random name.

That's not the case in DFU:
Ruler news.png
Ruler news.png (337.02 KiB) Viewed 380 times

User avatar
Ferital
Posts: 95
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.65: wrong ruler in "Any news"

Post by Ferital » Wed Mar 13, 2019 7:23 pm

After investigating how classic works, I confirm there is an issue there. I'll submit a PR when I'll have time.

In classic, when you get information about the new ruler of any country, the game looks at first for a faction of type "facINDIVIDUAL" using the same region id as the country. And since Factions.txt contains many bugs, this can lead to odd news like that:
The Great Knight Lord of Ilessan Hills.PNG
The Great Knight Lord of Ilessan Hills.PNG (88.69 KiB) Viewed 337 times
:D

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: 0.7.65: wrong ruler in "Any news"

Post by R.D. » Thu Mar 14, 2019 10:55 am

I found what the problem is. A faction's "flags" value is assigned from the faction file with =, when it should be |=. Some factions (Sentinel, at least), have their flags value across multiple lines for some reason. This causes only the last value to be used, so the "ruler immune" flag that is supposed to protect story factions from getting the new ruler event gets overwritten. I'm sending a PR for it now.

User avatar
Ferital
Posts: 95
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.65: wrong ruler in "Any news"

Post by Ferital » Thu Mar 14, 2019 1:34 pm

Great! :)

R.D.
Posts: 379
Joined: Fri Oct 07, 2016 10:41 am

Re: 0.7.65: wrong ruler in "Any news"

Post by R.D. » Sun Mar 24, 2019 8:02 am

Resolved now.

User avatar
Ferital
Posts: 95
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Post by Ferital » Thu Apr 11, 2019 8:25 am

The issue is still present:
Wrong ruler.PNG
Wrong ruler.PNG (230.83 KiB) Viewed 169 times

User avatar
Interkarma
Posts: 4287
Joined: Sun Mar 22, 2015 1:51 am

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Post by Interkarma » Thu Apr 11, 2019 10:05 am

Based on the nature of bug, any saves created prior to fix will likely still have issue. Source faction data is only read when character is created or persistent faction data is missing.

Something you could try is deleting the FactionFile.txt file from your save and reload game. This will force DFU to recreate the persistent faction data. Let me know if problem still persists after that and I'll re-open bug report. :)

User avatar
Nystul
Posts: 1326
Joined: Mon Mar 23, 2015 8:31 am

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Post by Nystul » Thu Apr 11, 2019 12:42 pm

or delete ConversationData.txt ;)

User avatar
Ferital
Posts: 95
Joined: Thu Apr 05, 2018 8:01 am

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Post by Ferital » Thu Apr 11, 2019 12:50 pm

I first deleted FactionData.txt and the problem was still there (this time with the King of Daggerfall not being Gothryd). I then deleted ConversationData.txt and I can't get any news since then, I always get something like "I try not to spread rumors", even if I set "talk_npcsKnowEverything" using the console command.

User avatar
Interkarma
Posts: 4287
Joined: Sun Mar 22, 2015 1:51 am

Re: 0.7.65: wrong ruler in "Any news" [RESOLVED]

Post by Interkarma » Thu Apr 11, 2019 8:39 pm

The rumours in "any news" are on a rotation. They're not related to "knows everything". You just need to pass time until they recycle. Travel around for about 30 days and they'll get repopulated. Once you've reset your faction data, the next rumours generated should have correct ruler names.

Post Reply