[NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect [RESOLVED]

Bug topics that have been resolved.
Post Reply
User avatar
kingOfWyrms
Posts: 50
Joined: Fri Aug 07, 2015 3:46 am

[NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect [RESOLVED]

Post by kingOfWyrms » Wed Jul 03, 2019 10:36 pm

Got a quest with with a residence location. Talking to an NPC got it marked on my map, but it doesn't show its name on inspection in world. I believe it may have been used already for a previous quest, though I'm not sure. It is the correct house, and the NPC to turn the quest in is in there and works properly though. Also, I don't have a save from before it was marked, so can't say whether inspection would have marked it on the map properly.

Named in the map:
Residence labelled in map.png
Residence labelled in map.png (207.08 KiB) Viewed 249 times
Just a "Residence" in-world:
Nameless on world inspection.png
Nameless on world inspection.png (414.23 KiB) Viewed 249 times
Attachments
SAVE10.zip
(192.76 KiB) Downloaded 3 times

User avatar
Interkarma
Posts: 4433
Joined: Sun Mar 22, 2015 1:51 am

Re: [NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect

Post by Interkarma » Thu Jul 04, 2019 7:56 am

I think this one is in Nystul's wheelhouse.

User avatar
Nystul
Posts: 1345
Joined: Mon Mar 23, 2015 8:31 am

Re: [NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect

Post by Nystul » Thu Jul 04, 2019 2:36 pm

will take a look soon ;)

User avatar
Nystul
Posts: 1345
Joined: Mon Mar 23, 2015 8:31 am

Re: [NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect

Post by Nystul » Mon Jul 08, 2019 10:00 am

pull request with fix issued

User avatar
pango
Posts: 1146
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect [RESOLVED]

Post by pango » Sun Jul 14, 2019 8:48 am

I have some issue: loading a game inside a building, going outside and opening town's map, I get an empty map. If I close it, I go back to the 3d view, but the game is totally frozen.

The log shows:

Code: Select all

NullReferenceException: Object reference not set to an instance of an object
  at DaggerfallWorkshop.Game.ExteriorAutomap.updateAutomapStateOnWindowPush () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterfaceWindows.DaggerfallExteriorAutomapWindow.OnPush () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.UserInterfaceManager.AddWindow (DaggerfallWorkshop.Game.UserInterface.UserInterfaceWindow window) [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.UserInterfaceManager.PushWindow (DaggerfallWorkshop.Game.UserInterface.UserInterfaceWindow window) [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.DaggerfallUI.ProcessMessages () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.DaggerfallUI.Update () [0x00000] in <filename unknown>:0 
 
NullReferenceException: Object reference not set to an instance of an object
  at DaggerfallWorkshop.Game.UserInterfaceWindows.DaggerfallExteriorAutomapWindow.OnPop () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.UserInterfaceManager.RemoveWindow () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.UserInterfaceManager.PopWindow () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.UserInterfaceWindow.CloseWindow () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterfaceWindows.DaggerfallExteriorAutomapWindow.ExitButton_OnMouseClick (DaggerfallWorkshop.Game.UserInterface.BaseScreenComponent sender, Vector2 position) [0x00000] in <filename unknown>:0 
  at (wrapper delegate-invoke) DaggerfallWorkshop.Game.UserInterface.BaseScreenComponent/OnMouseClickHandler:invoke_void__this___BaseScreenComponent_Vector2 (DaggerfallWorkshop.Game.UserInterface.BaseScreenComponent,UnityEngine.Vector2)
  at DaggerfallWorkshop.Game.UserInterface.BaseScreenComponent.MouseClick (Vector2 clickPosition) [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.BaseScreenComponent.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.Panel.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.Button.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.Panel.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.Panel.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterface.UserInterfaceWindow.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterfaceWindows.DaggerfallBaseWindow.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterfaceWindows.DaggerfallPopupWindow.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.UserInterfaceWindows.DaggerfallExteriorAutomapWindow.Update () [0x00000] in <filename unknown>:0 
  at DaggerfallWorkshop.Game.DaggerfallUI.Update () [0x00000] in <filename unknown>:0 
Bisecting points at commit 2b219142, which seems to be the fix for this bug report.
I don't quite understand why it breaks things, but reverting this commit prevents the above exceptions, so I'm rather confident it's the culpit.

I attach the gamesave to reproduce the issue, but I was using lots of mods, including Distant Terrain which is probably necessary to avoid relocation on load.
Attachments
SAVE45.zip
(394.4 KiB) Not downloaded yet
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

User avatar
Nystul
Posts: 1345
Joined: Mon Mar 23, 2015 8:31 am

Re: [NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect [RESOLVED]

Post by Nystul » Sun Jul 14, 2019 9:36 am

this has already been reported
bc2d340 commit in latest pull request (https://github.com/Interkarma/daggerfal ... /pull/1345) should fix it

fix is to return discovered instead of true

User avatar
pango
Posts: 1146
Joined: Wed Jul 18, 2018 6:14 pm
Location: France
Contact:

Re: [NYSTUL] Windows x64-91: House named on map, simply "Residence" on inspect [RESOLVED]

Post by pango » Sun Jul 14, 2019 11:52 am

Excellent, thanks!
When a measure becomes a target, it ceases to be a good measure.
-- Charles Goodhart

Post Reply