Daggerfall Workshop Forums

I was doing more mod testing and came across another bug.

I have the spell effect mod set up to AllowedCraftingStations=ItemMaker, but I didn't override the GetEnchantmentSettings(), so when the DaggerfallItemMakerWindow code tries to get the enchantment settings, it gets a null.

Line 252 in DaggerfallItemMakerWindow.cs attempts to check for null, but uses a bitwise-or instead of a logical-or.
Furthermore, it just produces a log message and continues processing when it should 'continue;' the loop instead.

This unhandled null object error results in Utility.StartGameBehaviour.Update() being called, causing it to get caught in an infinite loop.

Yup, looks like a nasty typo.
Found a similar one in Questing/Clock.cs:149: I pushed a fix https://github.com/Interkarma/daggerfal ... f143fff46f

Thank you Pango!