Page 1 of 2

(0.13.1) - You are allowed to rest inside shops [RESOLVED 0.13.5]

Posted: Tue Nov 02, 2021 10:10 pm
by Uncanny_Valley
You can fully rest and heal inside any shop. This feels like a bug, but not sure if this was the case in vanilla daggerfall.

Also a minor thing, when trying to rest inside someone's house or a guild (where you are not allowed to rest), you get the message that you haven't' rented a room there. This doesn't seem right either, but like above, it could just be how Daggerfall did it.

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Tue Nov 02, 2021 10:20 pm
by Jay_H
Reproduced for me in 0.13.1, no mods! I slept inside a general store in Daggerfall City.

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Wed Nov 03, 2021 12:37 am
by Interkarma
Well this one has slipped under the radar for a while. Exists as far back as 0.11.0, and probably earlier. That's just the oldest build I still have on hand.

Moving to issues to be fixed before 1.0.

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Thu Jan 06, 2022 6:38 pm
by Hazelnut
I can't reproduce this issue. I always get the message that I've not rented a room. In classic there's no message, when you press the rest button nothing happens and guards are spawned. This was discussed back when I was implementing renting rooms in taverns etc and IIRC we decided that the no warning calling the cops was a bit harsh. In DFU when outside in town you get a warning popup and then if you try again the halting starts. In buildings it's checking for whether player owns the building or has rented a room, and if not you get the message. The message is technically correct, even when shown for buildings you cannot rent a room at.

So how can I reproduce resting in shops then?

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Thu Jan 06, 2022 7:59 pm
by Jay_H
Well, here are my steps to reproduce it. Daggerfall City, 0.13.4 with no mods:


Re: (0.13.1) - You are allowed to rest inside shops

Posted: Thu Jan 06, 2022 11:02 pm
by Hazelnut
Thanks Jay, will take another look tomorrow.

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Fri Jan 07, 2022 11:00 am
by Hazelnut
This is strange, I cannot repro the issue at all. No mods, went to that exact shop and I still get message that not rented a room. Tried in editor and in release 0.13.4 and also with a brand new start in case it was my old saves.

The only way I can see this happening is if the conditional below evaluates to true in rest window CanRest() method:

Code: Select all

if (playerGPS.IsPlayerInTown(true, true))
This should never return true if the player is inside a building as the second parameter specifies they must be outside. This is governed by GameManager.Instance.IsPlayerInside - maybe that's not getting set properly? It is for me, resulting in not being able to rest but why is this happening for others?

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Fri Jan 07, 2022 11:10 am
by BadLuckBurt
Hazelnut wrote: Fri Jan 07, 2022 11:00 am It is for me, resulting in not being able to rest but why is this happening for others?
I will give this a try later this afternoon.

If anyone is able to trigger this consistently, could they provide a save?

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Fri Jan 07, 2022 12:51 pm
by BadLuckBurt
I would've edited my previous post but post editing seems to have been turned off.

I went to several stores in Daggerfall on a new character, including the store from Jay_H's video but I'm getting the same as Hazelnut, just a message that I haven't rented a room there. Loitering works fine.

I've also tried renting a room at one of the taverns and resting in a store after that, still the no room message.

Re: (0.13.1) - You are allowed to rest inside shops

Posted: Fri Jan 07, 2022 10:29 pm
by Interkarma
I can reproduce with attached save. Maybe related to character being a Knight and free room check?