Closed: Quests and reputation changes

Need something opened in the core for your mod, or even help with research?
User avatar
Hazelnut
Posts: 856
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Closed: Quests and reputation changes

Post by Hazelnut » Tue Mar 20, 2018 11:41 am

So, anyone paying attention knows I've implemented guild progression based on reputation and skills. Each guild quest successfully completed increases your rep with the guild faction by 5, and failing decreases by 2. This is the default case, but some quests shown on UESP have different reputation changes.

e.g. http://en.uesp.net/wiki/Daggerfall:Stil ... _with_Orcs and http://en.uesp.net/wiki/Daggerfall:More ... _with_Orcs

I know that the local region rep change is done in the quest script with "change repute with _local_ by +4" but how the extra guild faction rep increase is done is unknown. Can anyone confirm the numbers on UESP for a quest that it says should give more +rep than the default in classic? I've found the Dagrep tool is good for seeing rep changes, or just let me have a classic save just before quest hand in for any quest that UESP claims should give more than +5 rep for success.

This will be very valuable assistance for getting this part of DFU implemented correctly. UESP is incredibly helpful, but it cannot be blindly trusted because it does have discrepancies with the actual game.

User avatar
Hazelnut
Posts: 856
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Open: Quests and reputation changes

Post by Hazelnut » Wed Jun 13, 2018 3:01 pm

Is there anyone out there who wants to contribute and help Interkarma get DFU to Alpha this year then this is the perfect way to assist the project if you can spare some time. All you need is classic Daggerfall install and be able to play it up to quest hand in for one or more of the quests that have non-standard rep gain/loss on UESP. Then send me or post the zipped classic savefile, unless you want to analyse the rep changes yourself of course.

I will do this myself fairly soon, but that will use time I could be coding instead. ;)

User avatar
Jay_H
Posts: 1597
Joined: Tue Aug 25, 2015 1:54 am

Re: Open: Quests and reputation changes

Post by Jay_H » Wed Jun 13, 2018 8:33 pm

Ah, if it's that simple, then I can do that. Let me instead.
Try over 90 all-new quests in the first Daggerfall Unity Quest Pack.

User avatar
Hazelnut
Posts: 856
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Open: Quests and reputation changes

Post by Hazelnut » Wed Jun 13, 2018 10:01 pm

I thought you were busy and time-poor yourself with all your quest work you're doing... maybe someone else will volunteer? Lets give it a few days.

User avatar
Jay_H
Posts: 1597
Joined: Tue Aug 25, 2015 1:54 am

Re: Open: Quests and reputation changes

Post by Jay_H » Wed Jun 13, 2018 10:43 pm

Nah, this is simple. If it's directed towards something, I can do it very quickly. Testing and writing quests are bigger ordeals, but this is a few minutes at most.
Try over 90 all-new quests in the first Daggerfall Unity Quest Pack.

User avatar
Jay_H
Posts: 1597
Joined: Tue Aug 25, 2015 1:54 am

Re: Open: Quests and reputation changes

Post by Jay_H » Wed Jun 13, 2018 11:09 pm

Okay, I have them all in a zip file. I did a quest for the Mages Guild, the Fighters Guild, and a Knightly Order. Saves 0 to 2 are the "pre" and 3 to 5 are the "post" (it made more sense inside Daggerfall itself).
Try over 90 all-new quests in the first Daggerfall Unity Quest Pack.

User avatar
Hazelnut
Posts: 856
Joined: Sat Aug 26, 2017 2:46 pm
Contact:

Re: Open: Quests and reputation changes

Post by Hazelnut » Wed Jun 13, 2018 11:17 pm

Were they all quests marked as non-standard rep changes on UESP?

User avatar
Jay_H
Posts: 1597
Joined: Tue Aug 25, 2015 1:54 am

Re: Open: Quests and reputation changes

Post by Jay_H » Wed Jun 13, 2018 11:26 pm

Oops. Uh, I'll have to do that then. Yeah, I'll take some time to see that.
Try over 90 all-new quests in the first Daggerfall Unity Quest Pack.

User avatar
Jay_H
Posts: 1597
Joined: Tue Aug 25, 2015 1:54 am

Re: Open: Quests and reputation changes

Post by Jay_H » Wed Jun 13, 2018 11:41 pm

There, I did the quest you indicated, "More Trouble with Orcs." 2 is pre, 5 is post.
Attachments
Knightly Order.zip
(121.34 KiB) Downloaded 42 times
Try over 90 all-new quests in the first Daggerfall Unity Quest Pack.

R.D.
Posts: 301
Joined: Fri Oct 07, 2016 10:41 am

Re: Open: Quests and reputation changes

Post by R.D. » Thu Jun 14, 2018 11:31 am

I know that the local region rep change is done in the quest script with "change repute with _local_ by +4" but how the extra guild faction rep increase is done is unknown
I don't know this. I haven't done much on quest stuff, as there has been plenty of other things to focus on, but I'll try to chip away at it some soon. If I find out anything I'll let you know or submit a PR or something.

What I do know:
As far as I know all reputation changes in classic are done through the same function (except maybe the -2 for failing. I don't know where that is done), which we have a preliminary version of as ChangeReputation() in PersistentFactionData.cs. The propagation part is still a todo. The easy part of propagation is that half of the reputation change should be added to the PC's reputation with the faction's allies, and half of it subtracted from the faction's enemies (these are simple additions and subtractions, no propagation). But there a few other functions called, including some special cases in there for the Dark Brotherhood, knightly orders, etc. that I still need to figure out. I don't think it's anything too complicated.

Post Reply